Elements. Remove forOffset() constructors.

Change-Id: Idc0e19e8e6adb5a9b80efc7d63023693dbc65961
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/441362
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -3779,11 +3779,6 @@ sealed class FunctionFragmentImpl extends ExecutableFragmentImpl
   /// [offset].
   FunctionFragmentImpl({required this.name, required super.firstTokenOffset});
 
-  /// Initialize a newly created function element to have no name and the given
-  /// [nameOffset]. This is used for function expressions, that have no name.
-  FunctionFragmentImpl.forOffset({required super.firstTokenOffset})
-    : name = null;
-
   @override
   ExecutableFragmentImpl get declaration => this;
 }
@@ -3936,7 +3931,7 @@ class GenericFunctionTypeFragmentImpl extends FragmentImpl
 
   /// Initialize a newly created function element to have no name and the given
   /// [nameOffset]. This is used for function expressions, that have no name.
-  GenericFunctionTypeFragmentImpl.forOffset({required super.firstTokenOffset});
+  GenericFunctionTypeFragmentImpl({required super.firstTokenOffset});
 
   @override
   List<Fragment> get children => [...typeParameters, ...parameters];
@@ -6842,9 +6837,6 @@ class LocalFunctionFragmentImpl extends FunctionFragmentImpl
     required super.firstTokenOffset,
   });
 
-  LocalFunctionFragmentImpl.forOffset({required super.firstTokenOffset})
-    : super.forOffset();
-
   @override
   bool get _includeNameOffsetInIdentifier {
     return super._includeNameOffsetInIdentifier ||

pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart

@@ -786,7 +786,8 @@ class ResolutionVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitFunctionExpression(covariant FunctionExpressionImpl node) {
-    var fragment = LocalFunctionFragmentImpl.forOffset(
+    var fragment = LocalFunctionFragmentImpl(
+      name: null,
       firstTokenOffset: node.offset,
     );
 
@@ -901,7 +902,7 @@ class ResolutionVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitGenericFunctionType(GenericFunctionType node) {
-    var fragment = GenericFunctionTypeFragmentImpl.forOffset(
+    var fragment = GenericFunctionTypeFragmentImpl(
       firstTokenOffset: node.offset,
     );
     _unitElement.encloseElement(fragment);

pkg/analyzer/lib/src/summary2/ast_binary_reader.dart

@@ -694,9 +694,7 @@ class AstBinaryReader {
     var type = _reader.readRequiredType() as FunctionTypeImpl;
     node.type = type;
 
-    var fragment = GenericFunctionTypeFragmentImpl.forOffset(
-      firstTokenOffset: null,
-    );
+    var fragment = GenericFunctionTypeFragmentImpl(firstTokenOffset: null);
     fragment.parameters =
         formalParameters.parameters
             .map((parameter) => parameter.declaredFragment!)

pkg/analyzer/lib/src/summary2/bundle_reader.dart

@@ -1714,7 +1714,7 @@ class ResolutionReader {
       _localElements.length -= typeParameters.length;
 
       var fragment =
-          GenericFunctionTypeFragmentImpl.forOffset(firstTokenOffset: null)
+          GenericFunctionTypeFragmentImpl(firstTokenOffset: null)
             ..typeParameters = typeParameters
             ..parameters = formalParameters
             ..returnType = returnType;

pkg/analyzer/lib/src/summary2/element_builder.dart

@@ -1414,7 +1414,7 @@ class FragmentBuilder extends ThrowingAstVisitor<void> {
       node.parameters.accept(this);
     });
 
-    var aliasedElement = GenericFunctionTypeFragmentImpl.forOffset(
+    var aliasedElement = GenericFunctionTypeFragmentImpl(
       firstTokenOffset: null,
     );
     aliasedElement.parameters = holder.parameters;
@@ -1470,9 +1470,7 @@ class FragmentBuilder extends ThrowingAstVisitor<void> {
 
   @override
   void visitGenericFunctionType(covariant GenericFunctionTypeImpl node) {
-    var fragment = GenericFunctionTypeFragmentImpl.forOffset(
-      firstTokenOffset: null,
-    );
+    var fragment = GenericFunctionTypeFragmentImpl(firstTokenOffset: null);
     _unitElement.encloseElement(fragment);
 
     node.declaredFragment = fragment;