Analyzer plugins fix only responds to quick fix request on single point

[jensjoha]

I tried creating a lint and a fix.
I report the lint on the node (rule.reportAtNode(node)) (which has a huge length).
The lint shows up in the "problems view" in my IDE (VSCode), and from there I can right-click and is offered the fix.

Normally I do ctrl+. (asks for quickfix) when the cursor is inside the squiggly line - but that only appear to work when I'm at the first position (say there's a squiggly on foobar - if my cursor is at the start |foobar it works, but if I'm anywhere else it doesn't).

Am I holding something wrong or does it not work through the plugin as it does for normal lints/fixes?

/cc @srawlins

[FMorschel]

I see you use VS Code. Are you able to/familiar with running the server from source? Maybe that can help identify the issue? (Same for #61492).

I'm on Discord, and Dan is too. Feel free to reach out if you need help.

[jensjoha]

I am always running the analyzer from source, but I'm guessing Sam will immediately know what's up.

[srawlins]

Hmm, I didn't know offhand, but I see this code in analysis_server.dart:

var lintAtOffset = errors.where(
  (error) => error.diagnostic.offset == offset,
);

[srawlins]

Good catch, Jens! Thanks for reporting!

[bwilkerson]

... but I see this code in analysis_server.dart ...

That definitely looks suspicious; where is that?

The intended behavior is that fixes are shown if the cursor is anywhere on the same line as the offset of the highlight range.

[srawlins]

Sorry, I meant plugin_server.dart.

[bwilkerson]

Ok, thanks. The plugins should have the same behavior as the server in terms of which fixes are shown.