Skip to content

Commit e719ef6

Browse files
authored
Always release the Resolver instance (#125)
1 parent 20ea737 commit e719ef6

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 0.5.3+2
2+
3+
* BugFix: Always release the Resolver instance, even when generation does not
4+
run
5+
16
## 0.5.3+1
27

38
* Don't throw when running against a non-library asset and getting no

lib/src/builder.dart

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,13 @@ class GeneratorBuilder extends Builder {
3030
Future build(BuildStep buildStep) async {
3131
var id = buildStep.input.id;
3232
var resolver = await buildStep.resolve(id, resolveAllConstants: false);
33-
var lib = resolver.getLibrary(id);
34-
if (lib == null) return;
35-
await _generateForLibrary(lib, buildStep);
36-
resolver.release();
33+
try {
34+
var lib = resolver.getLibrary(id);
35+
if (lib == null) return;
36+
await _generateForLibrary(lib, buildStep);
37+
} finally {
38+
resolver.release();
39+
}
3740
}
3841

3942
@override

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: source_gen
2-
version: 0.5.3+1
2+
version: 0.5.3+2
33
author: Dart Team <[email protected]>
44
description: Automatic sourcecode generation for Dart
55
homepage: https://github.com/dart-lang/source_gen

0 commit comments

Comments
 (0)