[dwds] Cleanup unused null safety related fields

Author: nshahan

dwds/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 24.5.0-wip
+
+- Remove unused deprecated fields related to null safety.
+
 ## 24.4.1
 
 - Implemented a WebSocket-based communication protocol that provides essential developer tooling (hot reload, service extensions) when Chrome debugger access is unavailable. - [#2605](https://github.com/dart-lang/webdev/issues/2605)

dwds/lib/src/debugging/metadata/provider.dart

@@ -67,15 +67,6 @@ class MetadataProvider {
 
   MetadataProvider(this.entrypoint, this._assetReader);
 
-  /// A sound null safety mode for the whole app.
-  ///
-  /// All libraries have to agree on null safety mode.
-  @Deprecated('Only sound null safety is supported as of Dart 3.0')
-  Future<bool> get soundNullSafety async {
-    await _initialize();
-    return true;
-  }
-
   /// A list of all libraries in the Dart application.
   ///
   /// Example:

dwds/lib/src/services/expression_compiler.dart

@@ -6,15 +6,11 @@
 class CompilerOptions {
   final ModuleFormat moduleFormat;
 
-  @Deprecated('Only sound null safety is supported as of Dart 3.0')
-  final bool soundNullSafety;
-
   final bool canaryFeatures;
   final List<String> experiments;
 
   CompilerOptions({
     required this.moduleFormat,
-    this.soundNullSafety = true,
     required this.canaryFeatures,
     required this.experiments,
   });

dwds/lib/src/utilities/sdk_configuration.dart

@@ -47,12 +47,6 @@ class SdkLayout {
   final String summaryPath;
   final String dartdevcSnapshotPath;
 
-  @Deprecated('Only sound null safety is supported as of Dart 3.0')
-  final String soundSummaryPath;
-
-  @Deprecated('Only sound null safety is supported as of Dart 3.0')
-  final String weakSummaryPath;
-
   SdkLayout.createDefault(String sdkDirectory)
     : this(
         sdkDirectory: sdkDirectory,
@@ -73,8 +67,6 @@ class SdkLayout {
   const SdkLayout({
     required this.sdkDirectory,
     required this.summaryPath,
-    this.soundSummaryPath = '',
-    this.weakSummaryPath = '',
     required this.dartdevcSnapshotPath,
   });
 }
@@ -93,17 +85,9 @@ class SdkConfiguration {
   final String? sdkSummaryPath;
   final String? compilerWorkerPath;
 
-  @Deprecated('Only sound null safety is supported as of Dart 3.0')
-  final String? weakSdkSummaryPath;
-
-  @Deprecated('Only sound null safety is supported as of Dart 3.0')
-  final String? soundSdkSummaryPath;
-
   const SdkConfiguration({
     this.sdkDirectory,
     this.sdkSummaryPath,
-    this.weakSdkSummaryPath,
-    this.soundSdkSummaryPath,
     this.compilerWorkerPath,
   });
 
@@ -123,12 +107,6 @@ class SdkConfiguration {
   Uri? get sdkDirectoryUri => _toUri(sdkDirectory);
   Uri? get sdkSummaryUri => _toUri(sdkSummaryPath);
 
-  @Deprecated('Only sound null safety is supported as of Dart 3.0')
-  Uri? get soundSdkSummaryUri => _toUri(soundSdkSummaryPath);
-
-  @Deprecated('Only sound null safety is supported as of Dart 3.0')
-  Uri? get weakSdkSummaryUri => _toUri(weakSdkSummaryPath);
-
   /// Note: has to be ///file: Uri to run in an isolate.
   Uri? get compilerWorkerUri => _toAbsoluteUri(compilerWorkerPath);
 

dwds/test/sdk_configuration_test.dart

@@ -143,7 +143,7 @@ class FakeSdkLayout {
 
   FakeSdkLayout(this.sdkDirectory);
 
-  String get summaryPath => p.join(sdkDirectory, 'summaries', 'sound.dill');
+  String get summaryPath => p.join(sdkDirectory, 'summaries', 'outline.dill');
 
   String get compilerWorkerPath =>
       p.join(sdkDirectory, 'snapshots', 'test.snapshot');