Skip to content

Commit a7b8158

Browse files
authored
Don't run proper_release_test with the rest of the test common tests (#2146)
1 parent aa586d2 commit a7b8158

40 files changed

+145
-140
lines changed

.github/workflows/dart.yml

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/release_reminder.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88

99
jobs:
1010
release-reminder:
11-
if: ${{ !contains(github.event.*.labels.*.name, 'release-prep') }}
11+
if: ${{ !contains(github.event.*.labels.*.name, 'prepare-release') }}
1212
name: Maybe prevent submission
1313
runs-on: ubuntu-latest
1414
steps:
@@ -20,5 +20,5 @@ jobs:
2020
name: Checkout repository
2121
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
2222
- name: Run proper release test
23-
run: dart test test/proper_release_test.dart
23+
run: dart test test/proper_release_test.dart
2424
working-directory: test_common

dwds/debug_extension/tool/update_dev_files.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Future<void> _updateManifestJson() async {
3838
oldLine: line,
3939
newKey: 'default_icon',
4040
newValue: 'dart_dev.png',
41-
)
41+
),
4242
];
4343
}
4444
if (_matchesValue(line: line, value: 'background.js')) {
@@ -47,7 +47,7 @@ Future<void> _updateManifestJson() async {
4747
oldLine: line,
4848
newKey: null,
4949
newValue: 'background.dart.js',
50-
)
50+
),
5151
];
5252
} else {
5353
return [line];

dwds/debug_extension_mv3/tool/update_dev_files.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Future<void> _updateManifestJson() async {
3636
oldLine: line,
3737
newKey: 'default_icon',
3838
newValue: 'static_assets/dart_dev.png',
39-
)
39+
),
4040
];
4141
} else {
4242
return [line];

dwds/lib/src/debugging/classes.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class ClassHelper extends Domain {
2020
final staticClasses = [
2121
classRefForClosure,
2222
classRefForString,
23-
classRefForUnknown
23+
classRefForUnknown,
2424
];
2525
for (var classRef in staticClasses) {
2626
final classId = classRef.id;

dwds/lib/src/debugging/debugger.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ class Debugger extends Domain {
583583
'skipList': _skipLists.compute(
584584
scriptId,
585585
await _locations.locationsForUrl(url),
586-
)
586+
),
587587
},
588588
);
589589
return;

dwds/lib/src/debugging/inspector.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ class AppInspector implements AppInspectorInterface {
536536
// breakpoints. This is because the token positions are derived from the
537537
// DDC source maps which Chrome also uses.
538538
final tokenPositions = <int>[
539-
for (var location in mappedLocations) location.tokenPos
539+
for (var location in mappedLocations) location.tokenPos,
540540
];
541541
tokenPositions.sort();
542542

@@ -721,7 +721,7 @@ class AppInspector implements AppInspectorInterface {
721721
final parts = scripts[uri];
722722
final scriptRefs = [
723723
ScriptRef(uri: uri, id: createId()),
724-
for (var part in parts ?? []) ScriptRef(uri: part, id: createId())
724+
for (var part in parts ?? []) ScriptRef(uri: part, id: createId()),
725725
];
726726
final libraryRef = await _libraryHelper.libraryRefFor(uri);
727727
final libraryId = libraryRef?.id;

dwds/lib/src/debugging/instance.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ class InstanceHelper extends Domain {
479479
for (var i = positionalOffset + 1;
480480
i <= positionalOffset + positionalRangeCount;
481481
i++)
482-
i
482+
i,
483483
];
484484

485485
// Collect named fields in the requested range.

dwds/lib/src/debugging/location.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,8 +276,8 @@ class Locations {
276276
lineNumber,
277277
for (var location in locations) ...[
278278
location.tokenPos,
279-
location.dartLocation.column
280-
]
279+
location.dartLocation.column,
280+
],
281281
]);
282282
}
283283
_sourceToTokenPosTable[serverPath] = tokenPosTable;

dwds/lib/src/debugging/metadata/function.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class FunctionMetaData {
2929
}
3030
''';
3131
final arguments = [
32-
{'objectId': remoteObject.objectId}
32+
{'objectId': remoteObject.objectId},
3333
];
3434
final response = await remoteDebugger.sendCommand(
3535
'Runtime.callFunctionOn',

0 commit comments

Comments
 (0)