Skip to content

Commit 366c1cf

Browse files
committed
fixed linting issues
Signed-off-by: Nikhil Suri <[email protected]>
1 parent 26faa9b commit 366c1cf

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/databricks/sql/client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -326,13 +326,13 @@ def read(self) -> Optional[OAuthToken]:
326326
# Determine proxy usage
327327
use_proxy = self.http_client.using_proxy()
328328
proxy_host_info = None
329-
if use_proxy and self.http_client.proxy_uri:
329+
if use_proxy and self.http_client.proxy_uri and isinstance(self.http_client.proxy_uri, str):
330330
parsed = urlparse(self.http_client.proxy_uri)
331331
proxy_host_info = HostDetails(
332332
host_url=parsed.hostname or self.http_client.proxy_uri,
333-
port=parsed.port or 8080
333+
port=parsed.port or 8080,
334334
)
335-
335+
336336
driver_connection_params = DriverConnectionParameters(
337337
http_path=http_path,
338338
mode=DatabricksClientType.SEA

src/databricks/sql/telemetry/models/event.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,10 @@ class DriverErrorInfo(JsonSerializableMixin):
153153
class ChunkDetails(JsonSerializableMixin):
154154
"""
155155
Contains detailed metrics about chunk downloads during result fetching.
156-
156+
157157
These metrics are accumulated across all chunk downloads for a single statement.
158158
In Java, this is populated by the StatementTelemetryDetails tracker as chunks are downloaded.
159-
159+
160160
Tracking approach:
161161
- Initialize total_chunks_present from result manifest
162162
- For each chunk downloaded:
@@ -184,7 +184,7 @@ class ChunkDetails(JsonSerializableMixin):
184184
class ResultLatency(JsonSerializableMixin):
185185
"""
186186
Contains latency metrics for different phases of query execution.
187-
187+
188188
This tracks two distinct phases:
189189
1. result_set_ready_latency_millis: Time from query submission until results are available (execute phase)
190190
- Set when execute() completes
@@ -196,7 +196,7 @@ class ResultLatency(JsonSerializableMixin):
196196
Attributes:
197197
result_set_ready_latency_millis (int): Time until query results are ready (execution phase)
198198
result_set_consumption_latency_millis (int): Time spent fetching/consuming results (fetch phase)
199-
199+
200200
Note:
201201
Java implementation includes private field 'startTimeOfResultSetIterationNano' for internal
202202
tracking (not serialized to JSON). When implementing tracking in Python, use similar approach:
@@ -212,20 +212,20 @@ class ResultLatency(JsonSerializableMixin):
212212
class OperationDetail(JsonSerializableMixin):
213213
"""
214214
Contains detailed information about the operation being performed.
215-
215+
216216
This provides more granular operation tracking than statement_type, allowing
217217
differentiation between similar operations (e.g., EXECUTE_STATEMENT vs EXECUTE_STATEMENT_ASYNC).
218-
218+
219219
Tracking approach:
220220
- operation_type: Map method name to operation type enum
221221
* Java maps: executeStatement -> EXECUTE_STATEMENT
222222
* Java maps: listTables -> LIST_TABLES
223223
* Python could use similar mapping from method names
224-
224+
225225
- is_internal_call: Track if operation is initiated by driver internally
226226
* Set to true for driver-initiated metadata calls
227227
* Set to false for user-initiated operations
228-
228+
229229
- Status polling: For async operations
230230
* Increment n_operation_status_calls for each status check
231231
* Accumulate operation_status_latency_millis across all status calls

0 commit comments

Comments
 (0)