Fix failing tests

Author: samikshya-db

.github/workflows/publish-manual.yml

@@ -36,6 +36,14 @@ jobs:
           virtualenvs-in-project: true
           installer-parallel: true
 
+      #----------------------------------------------
+      # Step 3.5: Install Kerberos system dependencies
+      #----------------------------------------------
+      - name: Install Kerberos system dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libkrb5-dev
+
 #      #----------------------------------------------
 #      # Step 4: Load cached virtual environment (if available)
 #      #----------------------------------------------

.github/workflows/publish-test.yml

@@ -37,6 +37,10 @@ jobs:
       #----------------------------------------------
       # install dependencies if cache does not exist
       #----------------------------------------------
+      - name: Install Kerberos system dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libkrb5-dev
       - name: Install dependencies
         if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true'
         run: poetry install --no-interaction --no-root

.github/workflows/publish.yml

@@ -39,6 +39,10 @@ jobs:
       #----------------------------------------------
       # install dependencies if cache does not exist
       #----------------------------------------------
+      - name: Install Kerberos system dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libkrb5-dev
       - name: Install dependencies
         if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true'
         run: poetry install --no-interaction --no-root

tests/e2e/common/retry_test_mixins.py

@@ -278,7 +278,7 @@ def test_retry_max_count_not_exceeded(self, mock_send_telemetry, extra_params):
         THEN the connector issues six request (original plus five retries)
             before raising an exception
         """
-        with mocked_server_response(status=404) as mock_obj:
+        with mocked_server_response(status=429, headers={"Retry-After": "0"}) as mock_obj:
             with pytest.raises(MaxRetryError) as cm:
                 extra_params = {**extra_params, **self._retry_policy}
                 with self.connection(extra_params=extra_params) as conn:
@@ -467,22 +467,21 @@ def test_retry_safe_execute_statement_retry_condition(self, extra_params):
     )
     def test_retry_abort_close_session_on_404(self, extra_params, caplog):
         """GIVEN the connector sends a CloseSession command
-        WHEN server sends a 404 (which is normally retried)
-        THEN nothing is retried because 404 means the session already closed
+        WHEN server sends a 404 (which is not retried since commit 41b28159)
+        THEN nothing is retried because 404 is globally non-retryable
         """
 
-        # First response is a Bad Gateway -> Result is the command actually goes through
-        # Second response is a 404 because the session is no longer found
+        # With the idempotency-based retry refactor, 404 is now globally non-retryable
+        # regardless of command type. The close() method catches RequestError and proceeds.
         responses = [
-            {"status": 502, "headers": {"Retry-After": "1"}, "redirect_location": None},
             {"status": 404, "headers": {}, "redirect_location": None},
         ]
 
         extra_params = {**extra_params, **self._retry_policy}
         with self.connection(extra_params=extra_params) as conn:
             with mock_sequential_server_responses(responses):
+                # Should not raise an exception, the error is caught internally
                 conn.close()
-                assert "Session was closed by a prior request" in caplog.text
 
     @pytest.mark.parametrize(
         "extra_params",
@@ -493,14 +492,13 @@ def test_retry_abort_close_session_on_404(self, extra_params, caplog):
     )
     def test_retry_abort_close_operation_on_404(self, extra_params, caplog):
         """GIVEN the connector sends a CancelOperation command
-        WHEN server sends a 404 (which is normally retried)
-        THEN nothing is retried because 404 means the operation was already canceled
+        WHEN server sends a 404 (which is not retried since commit 41b28159)
+        THEN nothing is retried because 404 is globally non-retryable
         """
 
-        # First response is a Bad Gateway -> Result is the command actually goes through
-        # Second response is a 404 because the session is no longer found
+        # With the idempotency-based retry refactor, 404 is now globally non-retryable
+        # regardless of command type. The close() method catches RequestError and proceeds.
         responses = [
-            {"status": 502, "headers": {"Retry-After": "1"}, "redirect_location": None},
             {"status": 404, "headers": {}, "redirect_location": None},
         ]
 
@@ -515,10 +513,8 @@ def test_retry_abort_close_operation_on_404(self, extra_params, caplog):
                     # This call guarantees we have an open cursor at the server
                     curs.execute("SELECT 1")
                     with mock_sequential_server_responses(responses):
+                        # Should not raise an exception, the error is caught internally
                         curs.close()
-                        assert (
-                            "Operation was canceled by a prior request" in caplog.text
-                        )
 
     @pytest.mark.parametrize(
         "extra_params",

tests/e2e/common/staging_ingestion_tests.py

@@ -81,7 +81,7 @@ def test_staging_ingestion_life_cycle(self, ingestion_user):
             # GET after REMOVE should fail
 
             with pytest.raises(
-                Error, match="too many 404 error responses"
+                Error, match="Staging operation over HTTP was unsuccessful: 404"
             ):
                 cursor = conn.cursor()
                 query = f"GET 'stage://tmp/{ingestion_user}/tmp/11/16/file1.csv' TO '{new_temp_path}'"

tests/e2e/common/uc_volume_tests.py

@@ -81,7 +81,7 @@ def test_uc_volume_life_cycle(self, catalog, schema):
             # GET after REMOVE should fail
 
             with pytest.raises(
-                Error, match="too many 404 error responses"
+                Error, match="Staging operation over HTTP was unsuccessful: 404"
             ):
                 cursor = conn.cursor()
                 query = f"GET '/Volumes/{catalog}/{schema}/e2etests/file1.csv' TO '{new_temp_path}'"