[Feature] Add arm option to databricks_node_type instead of graviton (#5028)

## Changes
<!-- Summary of your changes that are easy to understand -->

`graviton` name is AWS specific and could be confusing for Azure users.
So deprecated `graviton` and added `arm` attribute instead.

Resolves #4128

## Tests
<!--
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [x] `make test` run locally
- [x] relevant change in `docs/` folder
- [x] has entry in `NEXT_CHANGELOG.md` file

Author: alexott

NEXT_CHANGELOG.md

@@ -6,6 +6,8 @@
 
 ### New Features and Improvements
 
+* Add `arm` option to `databricks_node_type` instead of `graviton` ([#5028](https://github.com/databricks/terraform-provider-databricks/pull/5028))
+
 ### Bug Fixes
 
 ### Documentation

access/resource_sql_permissions.go

@@ -280,7 +280,7 @@ func (ta *SqlPermissions) getOrCreateCluster(clustersAPI clusters.ClustersAPI) (
 		Latest:          true,
 		LongTermSupport: true,
 	})
-	nodeType := clustersAPI.GetSmallestNodeType(compute.NodeTypeRequest{LocalDisk: true})
+	nodeType := clustersAPI.GetSmallestNodeType(clusters.NodeTypeRequest{NodeTypeRequest: compute.NodeTypeRequest{LocalDisk: true}})
 	aclCluster, err := clustersAPI.GetOrCreateRunningCluster(
 		"terraform-table-acl", clusters.Cluster{
 			ClusterName:            "terraform-table-acl",

catalog/resource_sql_table.go

@@ -187,7 +187,7 @@ func (ti *SqlTableInfo) getOrCreateCluster(clusterName string, clustersAPI clust
 	sparkVersion := clusters.LatestSparkVersionOrDefault(clustersAPI.Context(), clustersAPI.WorkspaceClient(), compute.SparkVersionRequest{
 		Latest: true,
 	})
-	nodeType := clustersAPI.GetSmallestNodeType(compute.NodeTypeRequest{LocalDisk: true})
+	nodeType := clustersAPI.GetSmallestNodeType(clusters.NodeTypeRequest{NodeTypeRequest: compute.NodeTypeRequest{LocalDisk: true}})
 	aclCluster, err := clustersAPI.GetOrCreateRunningCluster(
 		clusterName, clusters.Cluster{
 			ClusterName:            clusterName,

clusters/clusters_api.go

@@ -892,8 +892,10 @@ func (a ClustersAPI) GetOrCreateRunningCluster(name string, custom ...Cluster) (
 			}
 		}
 	}
-	smallestNodeType := a.GetSmallestNodeType(compute.NodeTypeRequest{
-		LocalDisk: true,
+	smallestNodeType := a.GetSmallestNodeType(NodeTypeRequest{
+		NodeTypeRequest: compute.NodeTypeRequest{
+			LocalDisk: true,
+		},
 	})
 	log.Printf("[INFO] Creating an autoterminating cluster with node type %s", smallestNodeType)
 	r := Cluster{

clusters/data_node_type.go

@@ -6,13 +6,29 @@ import (
 
 	"github.com/databricks/databricks-sdk-go/service/compute"
 	"github.com/databricks/terraform-provider-databricks/common"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
 	"github.com/databricks/databricks-sdk-go"
 )
 
-func defaultSmallestNodeType(w *databricks.WorkspaceClient, request compute.NodeTypeRequest) string {
+type NodeTypeRequest struct {
+	compute.NodeTypeRequest
+	Arm bool `json:"arm,omitempty"`
+}
+
+func defaultSmallestNodeType(w *databricks.WorkspaceClient, request NodeTypeRequest) string {
+	if request.Arm || request.Graviton {
+		if w.Config.IsAws() {
+			if request.Fleet {
+				return "rgd-fleet.xlarge"
+			}
+			return "m6g.xlarge"
+		} else if w.Config.IsAzure() {
+			return "Standard_D4pds_v6"
+		}
+	}
 	if w.Config.IsAzure() {
-		return "Standard_D3_v2"
+		return "Standard_D4ds_v5"
 	} else if w.Config.IsGcp() {
 		return "n1-standard-4"
 	}
@@ -22,28 +38,33 @@ func defaultSmallestNodeType(w *databricks.WorkspaceClient, request compute.Node
 	return "i3.xlarge"
 }
 
-func smallestNodeType(ctx context.Context, request compute.NodeTypeRequest, w *databricks.WorkspaceClient) string {
+func smallestNodeType(ctx context.Context, request NodeTypeRequest, w *databricks.WorkspaceClient) string {
 	nodeTypes, err := w.Clusters.ListNodeTypes(ctx)
 	if err != nil {
 		return defaultSmallestNodeType(w, request)
 	}
-	nodeType, err := nodeTypes.Smallest(request)
+	// if arm is true, then graviton is true
+	request.Graviton = request.Arm || request.Graviton
+	nodeType, err := nodeTypes.Smallest(request.NodeTypeRequest)
 	if err != nil {
 		nodeType = defaultSmallestNodeType(w, request)
 	}
 	return nodeType
 }
 
-func (a ClustersAPI) GetSmallestNodeType(request compute.NodeTypeRequest) string {
+func (a ClustersAPI) GetSmallestNodeType(request NodeTypeRequest) string {
 	w, _ := a.client.WorkspaceClient()
 	return smallestNodeType(a.context, request, w)
 }
 
 // DataSourceNodeType returns smallest node depedning on the cloud
 func DataSourceNodeType() common.Resource {
-	return common.WorkspaceData(func(ctx context.Context, data *compute.NodeTypeRequest, w *databricks.WorkspaceClient) error {
+	return common.WorkspaceDataWithCustomizeFunc(func(ctx context.Context, data *NodeTypeRequest, w *databricks.WorkspaceClient) error {
 		data.Id = smallestNodeType(ctx, *data, w)
 		log.Printf("[DEBUG] smallest node: %s", data.Id)
 		return nil
+	}, func(s map[string]*schema.Schema) map[string]*schema.Schema {
+		common.CustomizeSchemaPath(s, "graviton").SetDeprecated("Use `arm` instead")
+		return s
 	})
 }

clusters/data_node_type_test.go

@@ -336,7 +336,7 @@ func TestNodeTypeEmptyList(t *testing.T) {
 		ID:          ".",
 	}.Apply(t)
 	assert.NoError(t, err)
-	assert.Equal(t, "Standard_D3_v2", d.Id())
+	assert.Equal(t, "Standard_D4ds_v5", d.Id())
 }
 
 func TestNodeTypeFleetEmptyList(t *testing.T) {

docs/data-sources/node_type.md

@@ -56,10 +56,11 @@ Data source allows you to pick groups by the following attributes
   * `GPU Accelerated` (AWS, Azure)
 * `photon_worker_capable` - (Optional) Pick only nodes that can run Photon workers. Defaults to _false_.
 * `photon_driver_capable` - (Optional) Pick only nodes that can run Photon driver. Defaults to _false_.
-* `graviton` - (boolean, optional)  if we should limit the search only to nodes with AWS Graviton or Azure Cobalt CPUs. Default to _false_.
+* `arm` - (boolean, optional)  if we should limit the search only to nodes with AWS Graviton or Azure Cobalt CPUs. Default to _false_.
 * `fleet` - (boolean, optional)  if we should limit the search only to [AWS fleet instance types](https://docs.databricks.com/compute/aws-fleet-instances.html). Default to _false_.
 * `is_io_cache_enabled` - (Optional) . Pick only nodes that have IO Cache. Defaults to _false_.
 * `support_port_forwarding` - (Optional) Pick only nodes that support port forwarding. Defaults to _false_.
+* `graviton` - (Deprecated. boolean, optional) if we should limit the search only to nodes with AWS Graviton or Azure Cobalt CPUs. Default to _false_. *Use `arm` instead!*
 
 ## Attribute Reference
 

storage/mounts.go

@@ -147,8 +147,10 @@ func getCommonClusterObject(clustersAPI clusters.ClustersAPI, clusterName string
 			LongTermSupport: true,
 		}),
 		NodeTypeID: clustersAPI.GetSmallestNodeType(
-			compute.NodeTypeRequest{
-				LocalDisk: true,
+			clusters.NodeTypeRequest{
+				NodeTypeRequest: compute.NodeTypeRequest{
+					LocalDisk: true,
+				},
 			}),
 		AutoterminationMinutes: 10,
 		SparkConf: map[string]string{