Skip to content

Commit ffa54bb

Browse files
committed
rename js_interop_tests to js_tests
It was too much to type
1 parent b52c91e commit ffa54bb

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ jobs:
3333
cargo check --all-targets
3434
cargo check --all-targets --no-default-features --features tokio
3535
cargo check --all-targets --no-default-features --features async-std
36-
cargo test --features js_interop_tests
37-
cargo test --no-default-features --features js_interop_tests,tokio
38-
cargo test --no-default-features --features js_interop_tests,async-std
36+
cargo test --features js_tests
37+
cargo test --no-default-features --features js_tests,tokio
38+
cargo test --no-default-features --features js_tests,async-std
3939
cargo test --benches
4040
4141
build-extra:

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ tokio = ["hypercore/tokio"]
7373
async-std = ["hypercore/async-std"]
7474
# Used only in interoperability tests under tests/js-interop which use the javascript version of hypercore
7575
# to verify that this crate works. To run them, use:
76-
# cargo test --features js_interop_tests
77-
js_interop_tests = []
76+
# cargo test --features js_tests
77+
js_tests = []
7878

7979
[profile.bench]
8080
# debug = true

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,10 @@ node examples-nodejs/run.js node
7272

7373
## Development
7474

75-
To test interoperability with Javascript, enable the `js_interop_tests` feature:
75+
To test interoperability with Javascript, enable the `js_tests` feature:
7676

7777
```bash
78-
cargo test --features js_interop_tests
78+
cargo test --features js_tests
7979
```
8080

8181
Run benches with:

tests/js_interop.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,56 +51,56 @@ const TEST_SET_CLIENT_WRITER: &str = "cw";
5151
const TEST_SET_SIMPLE: &str = "simple";
5252

5353
#[tokio::test]
54-
#[cfg_attr(not(feature = "js_interop_tests"), ignore)]
54+
#[cfg_attr(not(feature = "js_tests"), ignore)]
5555
async fn ncns_server_writer() -> Result<()> {
5656
ncns(true, 8101).await?;
5757
Ok(())
5858
}
5959

6060
#[tokio::test]
61-
#[cfg_attr(not(feature = "js_interop_tests"), ignore)]
61+
#[cfg_attr(not(feature = "js_tests"), ignore)]
6262
async fn ncns_client_writer() -> Result<()> {
6363
ncns(false, 8102).await?;
6464
Ok(())
6565
}
6666

6767
#[tokio::test]
68-
#[cfg_attr(not(feature = "js_interop_tests"), ignore)]
68+
#[cfg_attr(not(feature = "js_tests"), ignore)]
6969
async fn rcns_server_writer() -> Result<()> {
7070
rcns(true, 8103).await?;
7171
Ok(())
7272
}
7373

7474
#[tokio::test]
75-
#[cfg_attr(not(feature = "js_interop_tests"), ignore)]
75+
#[cfg_attr(not(feature = "js_tests"), ignore)]
7676
async fn rcns_client_writer() -> Result<()> {
7777
rcns(false, 8104).await?;
7878
Ok(())
7979
}
8080

8181
#[tokio::test]
82-
#[cfg_attr(not(feature = "js_interop_tests"), ignore)]
82+
#[cfg_attr(not(feature = "js_tests"), ignore)]
8383
async fn ncrs_server_writer() -> Result<()> {
8484
ncrs(true, 8105).await?;
8585
Ok(())
8686
}
8787

8888
#[tokio::test]
89-
#[cfg_attr(not(feature = "js_interop_tests"), ignore)]
89+
#[cfg_attr(not(feature = "js_tests"), ignore)]
9090
async fn ncrs_client_writer() -> Result<()> {
9191
ncrs(false, 8106).await?;
9292
Ok(())
9393
}
9494

9595
#[tokio::test]
96-
#[cfg_attr(not(feature = "js_interop_tests"), ignore)]
96+
#[cfg_attr(not(feature = "js_tests"), ignore)]
9797
async fn rcrs_server_writer() -> Result<()> {
9898
rcrs(true, 8107).await?;
9999
Ok(())
100100
}
101101

102102
#[tokio::test]
103-
//#[cfg_attr(not(feature = "js_interop_tests"), ignore)]
103+
//#[cfg_attr(not(feature = "js_tests"), ignore)]
104104
//#[ignore] // FIXME this tests hangs sporadically
105105
async fn rcrs_client_writer() -> Result<()> {
106106
rcrs(false, 8108).await?;

0 commit comments

Comments
 (0)