Skip to content

Conversation

@daviddiazvico
Copy link
Owner

@daviddiazvico daviddiazvico commented Apr 9, 2025

Fixing CI problems:

@daviddiazvico daviddiazvico requested a review from vnmabus April 9, 2025 10:25
@daviddiazvico daviddiazvico force-pushed the ci-update branch 2 times, most recently from c28cc01 to 600359d Compare April 9, 2025 11:03
@vnmabus
Copy link
Collaborator

vnmabus commented Apr 9, 2025

Tests will only be run in Python 3.10 (3.11 and 3.12 have issues with configparser, see pydata/pandas-datareader#969 and Theano/Theano#6807)

Do we depend on pandas-datareader or on Theano? If the error is raised at test time, maybe we can use skipif to skip the affected tests in the unsupported Python versions, which is better than not testing anything in those versions.

Another alternative is to install in CI the dependency directly from Github, as the error seems to have been fixed, although no new version with the fix has been released.

@daviddiazvico daviddiazvico force-pushed the ci-update branch 2 times, most recently from 49b45d2 to be3f14c Compare April 9, 2025 12:06
@daviddiazvico
Copy link
Owner Author

Do we depend on pandas-datareader or on Theano? If the error is raised at test time, maybe we can use skipif to skip the affected tests in the unsupported Python versions, which is better than not testing anything in those versions.

No, we don't, but I think we depend on configparser to set up all the tests.

Another alternative is to install in CI the dependency directly from Github, as the error seems to have been fixed, although no new version with the fix has been released.

I'll take a look at this.

@vnmabus
Copy link
Collaborator

vnmabus commented May 3, 2025

I'll take a look at this.

Did you have time to take a look?

@daviddiazvico daviddiazvico force-pushed the ci-update branch 9 times, most recently from d94039f to ec809e0 Compare October 4, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants