Skip to content

Commit bc05c63

Browse files
committed
iotests: Make verify_virtio_scsi_pci_or_ccw() public
It has no internal callers, so its only use is being called from individual test cases. If the name starts with an underscore, it is considered private and linters warn against calling it. 256 only gets away with it currently because it's on the exception list for linters. Signed-off-by: Kevin Wolf <[email protected]> Message-Id: <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
1 parent 8823407 commit bc05c63

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tests/qemu-iotests/256

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import os
2424
import iotests
2525
from iotests import log
2626

27-
iotests._verify_virtio_scsi_pci_or_ccw()
27+
iotests.verify_virtio_scsi_pci_or_ccw()
2828

2929
iotests.script_initialize(supported_fmts=['qcow2'])
3030
size = 64 * 1024 * 1024

tests/qemu-iotests/iotests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1421,7 +1421,7 @@ def _verify_virtio_blk() -> None:
14211421
if 'virtio-blk' not in out:
14221422
notrun('Missing virtio-blk in QEMU binary')
14231423

1424-
def _verify_virtio_scsi_pci_or_ccw() -> None:
1424+
def verify_virtio_scsi_pci_or_ccw() -> None:
14251425
out = qemu_pipe('-M', 'none', '-device', 'help')
14261426
if 'virtio-scsi-pci' not in out and 'virtio-scsi-ccw' not in out:
14271427
notrun('Missing virtio-scsi-pci or virtio-scsi-ccw in QEMU binary')

0 commit comments

Comments
 (0)