Skip to content

Commit f862ddb

Browse files
huthmstsirkin
authored andcommitted
hw/i386: Remove the deprecated pc-1.x machine types
They have been deprecated since QEMU v5.0, time to remove them now. Signed-off-by: Thomas Huth <[email protected]> Message-Id: <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Daniel P. Berrangé <[email protected]>
1 parent 958ec33 commit f862ddb

File tree

3 files changed

+6
-100
lines changed

3 files changed

+6
-100
lines changed

docs/system/deprecated.rst

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -322,12 +322,6 @@ The 'scsi-disk' device is deprecated. Users should use 'scsi-hd' or
322322
System emulator machines
323323
------------------------
324324

325-
``pc-1.0``, ``pc-1.1``, ``pc-1.2`` and ``pc-1.3`` (since 5.0)
326-
'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
327-
328-
These machine types are very old and likely can not be used for live migration
329-
from old QEMU versions anymore. A newer machine type should be used instead.
330-
331325
Raspberry Pi ``raspi2`` and ``raspi3`` machines (since 5.2)
332326
'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
333327

docs/system/removed-features.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,12 @@ mips ``fulong2e`` machine alias (removed in 6.0)
136136

137137
This machine has been renamed ``fuloong2e``.
138138

139+
``pc-1.0``, ``pc-1.1``, ``pc-1.2`` and ``pc-1.3`` (removed in 6.0)
140+
''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
141+
142+
These machine types were very old and likely could not be used for live
143+
migration from old QEMU versions anymore. Use a newer machine type instead.
144+
139145
Related binaries
140146
----------------
141147

hw/i386/pc_piix.c

Lines changed: 0 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -359,18 +359,6 @@ static void pc_compat_1_4_fn(MachineState *machine)
359359
pc_compat_1_5_fn(machine);
360360
}
361361

362-
static void pc_compat_1_3(MachineState *machine)
363-
{
364-
pc_compat_1_4_fn(machine);
365-
}
366-
367-
/* PC compat function for pc-1.0 to pc-1.2 */
368-
static void pc_compat_1_2(MachineState *machine)
369-
{
370-
pc_compat_1_3(machine);
371-
x86_cpu_change_kvm_default("kvm-pv-eoi", NULL);
372-
}
373-
374362
static void pc_init_isa(MachineState *machine)
375363
{
376364
pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE);
@@ -772,88 +760,6 @@ static void pc_i440fx_1_4_machine_options(MachineClass *m)
772760
DEFINE_I440FX_MACHINE(v1_4, "pc-i440fx-1.4", pc_compat_1_4_fn,
773761
pc_i440fx_1_4_machine_options);
774762

775-
static void pc_i440fx_1_3_machine_options(MachineClass *m)
776-
{
777-
X86MachineClass *x86mc = X86_MACHINE_CLASS(m);
778-
static GlobalProperty compat[] = {
779-
PC_CPU_MODEL_IDS("1.3.0")
780-
{ "usb-tablet", "usb_version", "1" },
781-
{ "virtio-net-pci", "ctrl_mac_addr", "off" },
782-
{ "virtio-net-pci", "mq", "off" },
783-
{ "e1000", "autonegotiation", "off" },
784-
};
785-
786-
pc_i440fx_1_4_machine_options(m);
787-
m->hw_version = "1.3.0";
788-
m->deprecation_reason = "use a newer machine type instead";
789-
x86mc->compat_apic_id_mode = true;
790-
compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat));
791-
}
792-
793-
DEFINE_I440FX_MACHINE(v1_3, "pc-1.3", pc_compat_1_3,
794-
pc_i440fx_1_3_machine_options);
795-
796-
797-
static void pc_i440fx_1_2_machine_options(MachineClass *m)
798-
{
799-
static GlobalProperty compat[] = {
800-
PC_CPU_MODEL_IDS("1.2.0")
801-
{ "nec-usb-xhci", "msi", "off" },
802-
{ "nec-usb-xhci", "msix", "off" },
803-
{ "qxl", "revision", "3" },
804-
{ "qxl-vga", "revision", "3" },
805-
{ "VGA", "mmio", "off" },
806-
};
807-
808-
pc_i440fx_1_3_machine_options(m);
809-
m->hw_version = "1.2.0";
810-
compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat));
811-
}
812-
813-
DEFINE_I440FX_MACHINE(v1_2, "pc-1.2", pc_compat_1_2,
814-
pc_i440fx_1_2_machine_options);
815-
816-
817-
static void pc_i440fx_1_1_machine_options(MachineClass *m)
818-
{
819-
static GlobalProperty compat[] = {
820-
PC_CPU_MODEL_IDS("1.1.0")
821-
{ "virtio-scsi-pci", "hotplug", "off" },
822-
{ "virtio-scsi-pci", "param_change", "off" },
823-
{ "VGA", "vgamem_mb", "8" },
824-
{ "vmware-svga", "vgamem_mb", "8" },
825-
{ "qxl-vga", "vgamem_mb", "8" },
826-
{ "qxl", "vgamem_mb", "8" },
827-
{ "virtio-blk-pci", "config-wce", "off" },
828-
};
829-
830-
pc_i440fx_1_2_machine_options(m);
831-
m->hw_version = "1.1.0";
832-
compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat));
833-
}
834-
835-
DEFINE_I440FX_MACHINE(v1_1, "pc-1.1", pc_compat_1_2,
836-
pc_i440fx_1_1_machine_options);
837-
838-
static void pc_i440fx_1_0_machine_options(MachineClass *m)
839-
{
840-
static GlobalProperty compat[] = {
841-
PC_CPU_MODEL_IDS("1.0")
842-
{ TYPE_ISA_FDC, "check_media_rate", "off" },
843-
{ "virtio-balloon-pci", "class", stringify(PCI_CLASS_MEMORY_RAM) },
844-
{ "apic-common", "vapic", "off" },
845-
{ TYPE_USB_DEVICE, "full-path", "no" },
846-
};
847-
848-
pc_i440fx_1_1_machine_options(m);
849-
m->hw_version = "1.0";
850-
compat_props_add(m->compat_props, compat, G_N_ELEMENTS(compat));
851-
}
852-
853-
DEFINE_I440FX_MACHINE(v1_0, "pc-1.0", pc_compat_1_2,
854-
pc_i440fx_1_0_machine_options);
855-
856-
857763
typedef struct {
858764
uint16_t gpu_device_id;
859765
uint16_t pch_device_id;

0 commit comments

Comments
 (0)