Skip to content

Commit fc8667f

Browse files
Apply suggestions from code review
Co-authored-by: Maximilian Franzke <[email protected]>
1 parent 540d19c commit fc8667f

File tree

4 files changed

+18
-10
lines changed

4 files changed

+18
-10
lines changed

.changeset/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ After the Release PR is merged into `main` branch:
6767
- Run the publish script (`scripts/github/publish-npm.js`)
6868
- Publish new versions to npm with the tag `latest` (or `next` for pre-releases)
6969
- Push git tags
70+
- Create a [GitHub Release](https://github.com/db-ux-design-system/core-web/releases)
7071

7172
You don’t have to run anything manually, it’s handled by CI.
7273

@@ -96,11 +97,11 @@ You don’t have to run anything manually, it’s handled by CI.
9697
- **Baseline snapshots**
9798

9899
ARIA snapshots by Playwright help detect markup changes. If they change, prefer minor instead of patch.
99-
And please mention those HTML changes within the `CHANGELOG`.
100+
And please mention those HTML changes within the `CHANGELOG` or of necessary (like bigger changes) in a [migration guide](https://github.com/db-ux-design-system/core-web/tree/main/docs/migration).
100101

101102
- **Avoid manual version bumps**
102103

103-
Never edit package.json `version` field by hand. Changesets handles this automatically.
104+
Never edit `package.json` `version` field by hand. Changesets handles this automatically.
104105

105106
---
106107

@@ -159,7 +160,7 @@ npx changeset
159160
npx changeset status --verbose
160161

161162
# Apply version bumps and changelogs
162-
npm run release:version
163+
npx changeset version
163164

164165
# Publish (if you want to do it locally, not in CI)
165166
npm run release:publish

.github/workflows/changesets-release-pr.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,16 @@ on:
1414
types: [opened, synchronize, reopened, ready_for_review]
1515
push:
1616
branches: ["main"]
17-
workflow_dispatch: {}
17+
workflow_dispatch:
18+
inputs:
19+
action:
20+
description: "Choose an action"
21+
required: true
22+
default: "version"
23+
type: choice
24+
options:
25+
- version
26+
- release
1827

1928
permissions:
2029
# Needed to push version commit + create releases
@@ -32,7 +41,7 @@ jobs:
3241
preview:
3342
if: github.event_name == 'pull_request'
3443
name: 🔎 Changesets Preview (PR)
35-
runs-on: ubuntu-latest
44+
runs-on: ubuntu-24.04
3645
steps:
3746
# Check out the PR HEAD commit (not the merge ref) to report the correct plan
3847
- name: ⏬ Checkout PR head (not merge ref)
@@ -99,7 +108,7 @@ jobs:
99108
# Only run on main pushes (merge to main done) to drive versioning + tags
100109
if: github.event_name == 'push' && startsWith(github.ref, 'refs/heads/main')
101110
name: 🧩 Create/Update Release PR (and cut tags/releases)
102-
runs-on: ubuntu-latest
111+
runs-on: ubuntu-24.04
103112

104113
steps:
105114
# Work on the main branch that was just pushed

.github/workflows/pull-request-snapshot-diff.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ concurrency:
2525
jobs:
2626
snapshot-diff:
2727
name: 🔎 Snapshot changes (png/yml) & bump guard
28-
runs-on: ubuntu-latest
28+
runs-on: ubuntu-24.04
2929

3030
steps:
3131
- # Check out the PR *head* commit (not the merge ref), with full history.
@@ -121,7 +121,7 @@ jobs:
121121
SNAP_SUMMARY_MD_PATH: ${{ env.SNAP_SUMMARY_MD_PATH }}
122122
with:
123123
script: |
124-
const fs = require('fs');
124+
const fs = require('node:fs');
125125
const { owner, repo, number } = context.issue;
126126
const marker = '<!-- snapshot-summary-marker -->';
127127
let body = '_No snapshot info._';

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@
6363
"regenerate:screenshots": "npm run build && npm run build --workspace=react-showcase && docker-compose --file ./e2e/docker-compose.regenerate.yml up",
6464
"regenerate:screenshots:rebuild": "npm run rm:builds && node scripts/rebuild-e2e.js",
6565
"release:publish": "node scripts/github/publish-npm.js",
66-
"release:status": "changeset status --verbose",
67-
"release:version": "changeset version",
6866
"rm:builds": "npm run rm:builds --workspace=scripts",
6967
"start": "npm run start --workspace=patternhub",
7068
"test": "npm run test --workspace=scripts",

0 commit comments

Comments
 (0)