diff --git a/__snapshots__/checkbox/showcase/chromium-highContrast/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png b/__snapshots__/checkbox/showcase/chromium-highContrast/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png index 5ac1364f1c64..6f3b83f8f16e 100644 Binary files a/__snapshots__/checkbox/showcase/chromium-highContrast/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png and b/__snapshots__/checkbox/showcase/chromium-highContrast/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png differ diff --git a/__snapshots__/checkbox/showcase/chromium/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png b/__snapshots__/checkbox/showcase/chromium/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png index 9ed8f4dc9045..8b4091853d6a 100644 Binary files a/__snapshots__/checkbox/showcase/chromium/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png and b/__snapshots__/checkbox/showcase/chromium/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png differ diff --git a/__snapshots__/checkbox/showcase/firefox/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png b/__snapshots__/checkbox/showcase/firefox/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png index cc0fb64b88e2..c689424408ab 100644 Binary files a/__snapshots__/checkbox/showcase/firefox/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png and b/__snapshots__/checkbox/showcase/firefox/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png differ diff --git a/__snapshots__/checkbox/showcase/mobile-chrome/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png b/__snapshots__/checkbox/showcase/mobile-chrome/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png index de59b7344d62..062808db856e 100644 Binary files a/__snapshots__/checkbox/showcase/mobile-chrome/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png and b/__snapshots__/checkbox/showcase/mobile-chrome/DBCheckbox-should-match-screenshot-1/DBCheckbox-should-match-screenshot.png differ diff --git a/__snapshots__/infotext/showcase/chromium-highContrast/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png b/__snapshots__/infotext/showcase/chromium-highContrast/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png index 4f3b82531a20..45fdda6db230 100644 Binary files a/__snapshots__/infotext/showcase/chromium-highContrast/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png and b/__snapshots__/infotext/showcase/chromium-highContrast/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png differ diff --git a/__snapshots__/infotext/showcase/chromium/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png b/__snapshots__/infotext/showcase/chromium/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png index 7b39608b6e22..1cdb0806afda 100644 Binary files a/__snapshots__/infotext/showcase/chromium/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png and b/__snapshots__/infotext/showcase/chromium/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png differ diff --git a/__snapshots__/infotext/showcase/firefox/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png b/__snapshots__/infotext/showcase/firefox/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png index b65942706b0d..5baea693c8c9 100644 Binary files a/__snapshots__/infotext/showcase/firefox/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png and b/__snapshots__/infotext/showcase/firefox/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png differ diff --git a/__snapshots__/infotext/showcase/mobile-chrome/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png b/__snapshots__/infotext/showcase/mobile-chrome/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png index 21299226ba4d..6e66ee0645f3 100644 Binary files a/__snapshots__/infotext/showcase/mobile-chrome/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png and b/__snapshots__/infotext/showcase/mobile-chrome/DBInfotext-should-match-screenshot-1/DBInfotext-should-match-screenshot.png differ diff --git a/__snapshots__/input/showcase/chromium-highContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/__snapshots__/input/showcase/chromium-highContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png index 6f8abc94cd7e..383a808c5f96 100644 Binary files a/__snapshots__/input/showcase/chromium-highContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png and b/__snapshots__/input/showcase/chromium-highContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png differ diff --git a/__snapshots__/input/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/__snapshots__/input/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml index 16b2a16b0203..d8426fa99be7 100644 --- a/__snapshots__/input/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/input/showcase/chromium-highContrast/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml @@ -86,14 +86,14 @@ - text: "True" - textbox "True" - status - - link "Show Icon Trailing" + - link "Show Icon Leading + Trailing" - text: "False" - textbox "False" - status - text: "True" - textbox "True" - status - - link "Show Icon Leading + Trailing" + - link "Show Icon Trailing" - text: "False" - textbox "False" - status diff --git a/__snapshots__/input/showcase/chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/__snapshots__/input/showcase/chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png index 527e3504d32c..2430944bc6e1 100644 Binary files a/__snapshots__/input/showcase/chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png and b/__snapshots__/input/showcase/chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png differ diff --git a/__snapshots__/input/showcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/__snapshots__/input/showcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml index 16b2a16b0203..d8426fa99be7 100644 --- a/__snapshots__/input/showcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/input/showcase/chromium/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml @@ -86,14 +86,14 @@ - text: "True" - textbox "True" - status - - link "Show Icon Trailing" + - link "Show Icon Leading + Trailing" - text: "False" - textbox "False" - status - text: "True" - textbox "True" - status - - link "Show Icon Leading + Trailing" + - link "Show Icon Trailing" - text: "False" - textbox "False" - status diff --git a/__snapshots__/input/showcase/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/__snapshots__/input/showcase/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png index e97c716ff04e..67f497090219 100644 Binary files a/__snapshots__/input/showcase/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png and b/__snapshots__/input/showcase/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png differ diff --git a/__snapshots__/input/showcase/firefox/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/__snapshots__/input/showcase/firefox/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml index 16b2a16b0203..d8426fa99be7 100644 --- a/__snapshots__/input/showcase/firefox/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/input/showcase/firefox/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml @@ -86,14 +86,14 @@ - text: "True" - textbox "True" - status - - link "Show Icon Trailing" + - link "Show Icon Leading + Trailing" - text: "False" - textbox "False" - status - text: "True" - textbox "True" - status - - link "Show Icon Leading + Trailing" + - link "Show Icon Trailing" - text: "False" - textbox "False" - status diff --git a/__snapshots__/input/showcase/mobile-chrome/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png b/__snapshots__/input/showcase/mobile-chrome/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png index 8024671c86c0..b0b70b86fd9a 100644 Binary files a/__snapshots__/input/showcase/mobile-chrome/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png and b/__snapshots__/input/showcase/mobile-chrome/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png differ diff --git a/__snapshots__/input/showcase/mobile-chrome/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/__snapshots__/input/showcase/mobile-chrome/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml index 16b2a16b0203..d8426fa99be7 100644 --- a/__snapshots__/input/showcase/mobile-chrome/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/input/showcase/mobile-chrome/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml @@ -86,14 +86,14 @@ - text: "True" - textbox "True" - status - - link "Show Icon Trailing" + - link "Show Icon Leading + Trailing" - text: "False" - textbox "False" - status - text: "True" - textbox "True" - status - - link "Show Icon Leading + Trailing" + - link "Show Icon Trailing" - text: "False" - textbox "False" - status diff --git a/__snapshots__/input/showcase/mobile-safari/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/__snapshots__/input/showcase/mobile-safari/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml index 16b2a16b0203..d8426fa99be7 100644 --- a/__snapshots__/input/showcase/mobile-safari/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/input/showcase/mobile-safari/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml @@ -86,14 +86,14 @@ - text: "True" - textbox "True" - status - - link "Show Icon Trailing" + - link "Show Icon Leading + Trailing" - text: "False" - textbox "False" - status - text: "True" - textbox "True" - status - - link "Show Icon Leading + Trailing" + - link "Show Icon Trailing" - text: "False" - textbox "False" - status diff --git a/__snapshots__/input/showcase/webkit/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml b/__snapshots__/input/showcase/webkit/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml index 16b2a16b0203..d8426fa99be7 100644 --- a/__snapshots__/input/showcase/webkit/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml +++ b/__snapshots__/input/showcase/webkit/should-have-same-aria-snapshot/DBInput-should-have-same-aria-snapshot.yaml @@ -86,14 +86,14 @@ - text: "True" - textbox "True" - status - - link "Show Icon Trailing" + - link "Show Icon Leading + Trailing" - text: "False" - textbox "False" - status - text: "True" - textbox "True" - status - - link "Show Icon Leading + Trailing" + - link "Show Icon Trailing" - text: "False" - textbox "False" - status diff --git a/__snapshots__/link/showcase/chromium-highContrast/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png b/__snapshots__/link/showcase/chromium-highContrast/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png index c74df2230ff1..e3a0bb98afd7 100644 Binary files a/__snapshots__/link/showcase/chromium-highContrast/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png and b/__snapshots__/link/showcase/chromium-highContrast/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png differ diff --git a/__snapshots__/link/showcase/chromium/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png b/__snapshots__/link/showcase/chromium/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png index 279b2164d600..f7a05a73683e 100644 Binary files a/__snapshots__/link/showcase/chromium/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png and b/__snapshots__/link/showcase/chromium/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png differ diff --git a/__snapshots__/link/showcase/firefox/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png b/__snapshots__/link/showcase/firefox/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png index d879afde9c2c..86a1cf08ebcd 100644 Binary files a/__snapshots__/link/showcase/firefox/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png and b/__snapshots__/link/showcase/firefox/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png differ diff --git a/__snapshots__/link/showcase/mobile-chrome/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png b/__snapshots__/link/showcase/mobile-chrome/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png index fff8c24ca65e..66ece00bf02b 100644 Binary files a/__snapshots__/link/showcase/mobile-chrome/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png and b/__snapshots__/link/showcase/mobile-chrome/DBLink-should-match-screenshot-1/DBLink-should-match-screenshot.png differ diff --git a/__snapshots__/radio/showcase/chromium-highContrast/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png b/__snapshots__/radio/showcase/chromium-highContrast/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png index 539ba01bb63b..fe252e978069 100644 Binary files a/__snapshots__/radio/showcase/chromium-highContrast/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png and b/__snapshots__/radio/showcase/chromium-highContrast/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png differ diff --git a/__snapshots__/radio/showcase/chromium/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png b/__snapshots__/radio/showcase/chromium/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png index 5e909d7b08ed..d09975b71efb 100644 Binary files a/__snapshots__/radio/showcase/chromium/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png and b/__snapshots__/radio/showcase/chromium/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png differ diff --git a/__snapshots__/radio/showcase/firefox/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png b/__snapshots__/radio/showcase/firefox/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png index 48373661672c..dcc5dbd5ca8d 100644 Binary files a/__snapshots__/radio/showcase/firefox/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png and b/__snapshots__/radio/showcase/firefox/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png differ diff --git a/__snapshots__/radio/showcase/mobile-chrome/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png b/__snapshots__/radio/showcase/mobile-chrome/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png index eefa98806afc..03725ad3103a 100644 Binary files a/__snapshots__/radio/showcase/mobile-chrome/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png and b/__snapshots__/radio/showcase/mobile-chrome/DBRadio-should-match-screenshot-1/DBRadio-should-match-screenshot.png differ diff --git a/docs/migration/v2.x.x-to-v3.0.0.md b/docs/migration/v2.x.x-to-v3.0.0.md index cfa64dc95e56..6144f019c0f4 100644 --- a/docs/migration/v2.x.x-to-v3.0.0.md +++ b/docs/migration/v2.x.x-to-v3.0.0.md @@ -30,7 +30,6 @@ Please provide the correct `type` property in your code anyhow as a best practis We removed the `state` property from the `db-button`/`DBButton` component for now. It wasn't implemented in any framework causing some confusion, and we will reintroduce it in a future version. - ## db-card/DBCard ### `behavior='interactive'` change diff --git a/package-lock.json b/package-lock.json index 17c84951c9ae..e17934d4ac86 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11237,6 +11237,7 @@ }, "node_modules/@parcel/watcher-wasm/node_modules/napi-wasm": { "version": "1.1.0", + "extraneous": true, "inBundle": true, "license": "MIT" }, diff --git a/packages/components/src/components/brand/brand.lite.tsx b/packages/components/src/components/brand/brand.lite.tsx index e05d451a7c09..de0f9e2b64fe 100644 --- a/packages/components/src/components/brand/brand.lite.tsx +++ b/packages/components/src/components/brand/brand.lite.tsx @@ -6,7 +6,7 @@ import { useStore } from '@builder.io/mitosis'; import { DEFAULT_ICON } from '../../shared/constants'; -import { cls, getHideProp } from '../../utils'; +import { cls, getBooleanAsString } from '../../utils'; import { DBBrandProps, DBBrandState } from './model'; useMetadata({}); @@ -23,7 +23,7 @@ export default function DBBrand(props: DBBrandProps) {
diff --git a/packages/components/src/components/button/button.lite.tsx b/packages/components/src/components/button/button.lite.tsx index de64b5f91534..e070d3033f68 100644 --- a/packages/components/src/components/button/button.lite.tsx +++ b/packages/components/src/components/button/button.lite.tsx @@ -5,7 +5,7 @@ import { useRef, useStore } from '@builder.io/mitosis'; -import { cls, getBoolean, getBooleanAsString, getHideProp } from '../../utils'; +import { cls, getBoolean, getBooleanAsString } from '../../utils'; import type { DBButtonProps, DBButtonState } from './model'; useMetadata({ @@ -38,11 +38,11 @@ export default function DBButton(props: DBButtonProps) { type={state.getButtonType()} disabled={getBoolean(props.disabled, 'disabled')} data-icon={props.iconLeading ?? props.icon} - data-hide-icon={getHideProp( + data-show-icon={getBooleanAsString( props.showIconLeading ?? props.showIcon )} data-icon-trailing={props.iconTrailing} - data-hide-icon-trailing={getHideProp(props.showIconTrailing)} + data-show-icon-trailing={getBooleanAsString(props.showIconTrailing)} data-size={props.size} data-width={props.width} data-variant={props.variant} diff --git a/packages/components/src/components/checkbox/checkbox.scss b/packages/components/src/components/checkbox/checkbox.scss index 890b609cfc87..8b173a14aa89 100644 --- a/packages/components/src/components/checkbox/checkbox.scss +++ b/packages/components/src/components/checkbox/checkbox.scss @@ -135,7 +135,7 @@ border-width: form-components.$check-border-size; - &:not([data-hide-icon-leading="true"])::before { + &:not([data-show-icon-leading="false"])::before { align-content: center; font-size: calc( var(--db-icon-font-size) - 2 * diff --git a/packages/components/src/components/custom-select-list-item/custom-select-list-item.lite.tsx b/packages/components/src/components/custom-select-list-item/custom-select-list-item.lite.tsx index f36acc0ae7f3..c12851759843 100644 --- a/packages/components/src/components/custom-select-list-item/custom-select-list-item.lite.tsx +++ b/packages/components/src/components/custom-select-list-item/custom-select-list-item.lite.tsx @@ -9,13 +9,7 @@ import { useTarget } from '@builder.io/mitosis'; import { ChangeEvent } from '../../shared/model'; -import { - cls, - getBoolean, - getBooleanAsString, - getHideProp, - uuid -} from '../../utils'; +import { cls, getBoolean, getBooleanAsString, uuid } from '../../utils'; import { handleFrameworkEventAngular, handleFrameworkEventVue @@ -95,7 +89,7 @@ export default function DBCustomSelectListItem( ? props.icon : undefined } - data-hide-icon={getHideProp(props.showIcon)} + data-show-icon={getBooleanAsString(props.showIcon)} data-icon-trailing={state.getIconTrailing()}> + data-show-icon={getBooleanAsString(props.showIcon)}>