Empty pie could be grey

[tedberg]

Go to demo page: https://dc-js.github.io/dc.js/

Use selectors to make pie charts empty. The default style has white text on a pink background.

[gordonwoodhull]

Yes, it is pink. It is a special case for empty pie charts that is styled in CSS, implemented in #447. Previously the chart displayed blank.

https://github.com/dc-js/dc.js/blob/develop/dc.css#L30

If this color offends you, you can specify your own color in a rule for .dc-chart .empty-chart .pie-slice path

[tedberg]

Yes, this is what I do to change it to a shade of light gray. I match the color used for excluded slices when another slice is selected.

I would think most people would equate null to a color like that. Bug was just a suggestion to default to grey.

Sent from my iPhone

On Apr 29, 2016, at 12:52 PM, Gordon Woodhull notifications@github.com wrote:

Yes, it is pink. It is a special case that is styled in CSS.

https://github.com/dc-js/dc.js/blob/develop/dc.css#L30

If this color offends you, you can specify your own color in a rule for .dc-chart .empty-chart .pie-slice path

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[gordonwoodhull]

I see. Sure, the "excluded color" may be a better default here. Thanks for clarifying.