Skip to content

Commit 9273c66

Browse files
authored
fix: add support for multiple hostnames (#55)
1 parent d11aaf3 commit 9273c66

File tree

3 files changed

+36
-5
lines changed

3 files changed

+36
-5
lines changed

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ Then restart your project
2626
ddev restart
2727
```
2828

29+
> [!NOTE]
30+
> If you change `additional_hostnames` or `additional_fqdns`, you have to re-run `ddev add-on get ddev/ddev-selenium-standalone-chrome`
31+
2932
### Optional steps
3033

3134
1. Update the provided `.ddev/config.selenium-standalone-chrome.yaml` as you see fit (and remove the #ddev-generated line). You can also just override lines in your `.ddev/config.yaml`

docker-compose.selenium-chrome.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ services:
1717
- HTTPS_EXPOSE=7900:7900
1818
- HTTP_EXPOSE=7910:7900
1919
- VNC_NO_PASSWORD=1
20-
external_links:
21-
- ddev-router:${DDEV_SITENAME}.${DDEV_TLD}
2220
# To enable VNC access for traditional VNC clients like macOS "Screen Sharing",
2321
# uncomment the following two lines.
2422
#ports:

install.yaml

Lines changed: 33 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,38 @@
11
name: ddev-selenium-standalone-chrome
2-
pre_install_actions:
2+
33
project_files:
44
- docker-compose.selenium-chrome.yaml
55
- config.selenium-standalone-chrome.yaml
6-
global_files:
6+
77
post_install_actions:
8-
yaml_read_files:
8+
- |
9+
#ddev-nodisplay
10+
#ddev-description:Checking docker-compose.selenium-chrome_extras.yaml for changes
11+
if [ -f docker-compose.selenium-chrome_extras.yaml ] && ! grep -q '#ddev-generated' docker-compose.selenium-chrome_extras.yaml; then
12+
echo "Existing docker-compose.selenium-chrome_extras.yaml does not have #ddev-generated, so can't be updated"
13+
exit 2
14+
fi
15+
- |
16+
#ddev-nodisplay
17+
#ddev-description:Adding all hostnames to the selenium-chrome container to make them available
18+
cat <<-END >docker-compose.selenium-chrome_extras.yaml
19+
#ddev-generated
20+
services:
21+
selenium-chrome:
22+
external_links:
23+
{{- $selenium_chrome_hostnames := splitList "," (env "DDEV_HOSTNAME") -}}
24+
{{- range $i, $n := $selenium_chrome_hostnames }}
25+
- "ddev-router:{{- replace (env "DDEV_TLD") "\\${DDEV_TLD}" (replace (env "DDEV_PROJECT") "\\${DDEV_PROJECT}" $n) -}}"
26+
{{- end }}
27+
END
28+
removal_actions:
29+
- |
30+
#ddev-nodisplay
31+
#ddev-description:Remove docker-compose.selenium-chrome_extras.yaml file
32+
if [ -f docker-compose.selenium-chrome_extras.yaml ]; then
33+
if grep -q '#ddev-generated' docker-compose.selenium-chrome_extras.yaml; then
34+
rm -f docker-compose.selenium-chrome_extras.yaml
35+
else
36+
echo "Unwilling to remove '$DDEV_APPROOT/.ddev/docker-compose.selenium-chrome_extras.yaml' because it does not have #ddev-generated in it; you can manually delete it if it is safe to delete."
37+
fi
38+
fi

0 commit comments

Comments
 (0)