Skip to content

Commit 44994cc

Browse files
authored
Merge pull request #10 from akasarto/unitTestDecimals
Parse unit test decimals using invariant culture.
2 parents 84cec81 + f1199a9 commit 44994cc

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

test/ApacheOrcDotNet.OptimizedReader.Test/OrcReader_Test.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using ApacheOrcDotNet.Protocol;
22
using System;
3+
using System.Globalization;
34
using System.Linq;
45
using Xunit;
56

@@ -49,8 +50,8 @@ public void FileColumnStatistics()
4950
Assert.Equal(35, reader.GetFileColumnStatistics(2).IntStatistics.Maximum);
5051
Assert.Equal(311, reader.GetFileColumnStatistics(3).IntStatistics.Minimum);
5152
Assert.Equal(596293502, reader.GetFileColumnStatistics(3).IntStatistics.Maximum);
52-
Assert.Equal(9.392m, decimal.Parse(reader.GetFileColumnStatistics(5).DecimalStatistics.Minimum));
53-
Assert.Equal(72041.725554m, decimal.Parse(reader.GetFileColumnStatistics(5).DecimalStatistics.Maximum));
53+
Assert.Equal(9.392m, decimal.Parse(reader.GetFileColumnStatistics(5).DecimalStatistics.Minimum, CultureInfo.InvariantCulture));
54+
Assert.Equal(72041.725554m, decimal.Parse(reader.GetFileColumnStatistics(5).DecimalStatistics.Maximum, CultureInfo.InvariantCulture));
5455
}
5556

5657
[Fact]
@@ -63,8 +64,8 @@ public void StripeColumnStatistics()
6364
Assert.Equal(35, reader.GetStripeColumnStatistics(2, 0).IntStatistics.Maximum);
6465
Assert.Equal(311, reader.GetStripeColumnStatistics(3, 0).IntStatistics.Minimum);
6566
Assert.Equal(16690225, reader.GetStripeColumnStatistics(3, 0).IntStatistics.Maximum);
66-
Assert.Equal(25200.063318m, decimal.Parse(reader.GetStripeColumnStatistics(5, 0).DecimalStatistics.Minimum));
67-
Assert.Equal(71979.49409m, decimal.Parse(reader.GetStripeColumnStatistics(5, 0).DecimalStatistics.Maximum));
67+
Assert.Equal(25200.063318m, decimal.Parse(reader.GetStripeColumnStatistics(5, 0).DecimalStatistics.Minimum, CultureInfo.InvariantCulture));
68+
Assert.Equal(71979.49409m, decimal.Parse(reader.GetStripeColumnStatistics(5, 0).DecimalStatistics.Maximum, CultureInfo.InvariantCulture));
6869
}
6970

7071
[Fact]

test/ApacheOrcDotNet.Test/ColumnTypes/DecimalReader_Test.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
using ApacheOrcDotNet.ColumnTypes;
22
using ApacheOrcDotNet.Stripes;
33
using ApacheOrcDotNet.Test.TestHelpers;
4-
using System;
5-
using System.Collections.Generic;
4+
using System.Globalization;
65
using System.Linq;
7-
using System.Threading.Tasks;
86
using Xunit;
97

108
namespace ApacheOrcDotNet.Test.ColumnTypes
@@ -36,7 +34,7 @@ public void ReadColumn1_ShouldProduceExpectedResults()
3634
{
3735
var decimalPortion= 5 + i;
3836
var wholePortion = -1000 + i;
39-
expected = decimal.Parse($"{wholePortion}.{decimalPortion}");
37+
expected = decimal.Parse($"{wholePortion}.{decimalPortion}", CultureInfo.InvariantCulture);
4038
}
4139
else if(i<4000)
4240
{
@@ -46,7 +44,7 @@ public void ReadColumn1_ShouldProduceExpectedResults()
4644
{
4745
var decimalPortion = (i - 4000) + 1;
4846
var wholePortion = (i - 4000);
49-
expected = decimal.Parse($"{wholePortion}.{decimalPortion}");
47+
expected = decimal.Parse($"{wholePortion}.{decimalPortion}", CultureInfo.InvariantCulture);
5048
}
5149
Assert.Equal(expected, results[i]);
5250
}

0 commit comments

Comments
 (0)