client/db: Upgrade to version seven.

Author: JoeGruffins

client/db/bolt/upgrades.go

@@ -42,6 +42,9 @@ var upgrades = [...]upgradefunc{
 	v5Upgrade,
 	// v5 => v6 splits matches into separate active and archived buckets.
 	v6Upgrade,
+	// v6 => v7 sets the status of all refunded matches to order.MatchConfirmed
+	// status.
+	v7Upgrade,
 }
 
 // DBVersion is the latest version of the database that is understood. Databases
@@ -366,6 +369,65 @@ func v6Upgrade(dbtx *bbolt.Tx) error {
 	})
 }
 
+// v7Upgrade sets the status to all archived refund matches to order.MatchConfirmed.
+// From now on all refunds must also have confirmations for the trade to be
+// considered inactive.
+func v7Upgrade(dbtx *bbolt.Tx) error {
+	const oldVersion = 6
+
+	if err := ensureVersion(dbtx, oldVersion); err != nil {
+		return err
+	}
+
+	amb := []byte("matches") // archived matches
+
+	var nRefunded int
+
+	defer func() {
+		upgradeLog.Infof("%d inactive refunded matches set to confirmed status", nRefunded)
+	}()
+
+	archivedMatchesBkt := dbtx.Bucket(amb)
+
+	return archivedMatchesBkt.ForEach(func(k, _ []byte) error {
+		archivedMBkt := archivedMatchesBkt.Bucket(k)
+		if archivedMBkt == nil {
+			return fmt.Errorf("match %x bucket is not a bucket", k)
+		}
+		matchB := getCopy(archivedMBkt, matchKey)
+		if matchB == nil {
+			return fmt.Errorf("nil match bytes for %x", k)
+		}
+		match, _, err := order.DecodeMatch(matchB)
+		if err != nil {
+			return fmt.Errorf("error decoding match %x: %w", k, err)
+		}
+		proofB := getCopy(archivedMBkt, proofKey)
+		if len(proofB) == 0 {
+			return fmt.Errorf("empty proof")
+		}
+		proof, _, err := dexdb.DecodeMatchProof(proofB)
+		if err != nil {
+			return fmt.Errorf("error decoding proof: %w", err)
+		}
+
+		// Check if refund.
+		if len(proof.RefundCoin) == 0 {
+			return nil
+		}
+		nRefunded++
+
+		match.Status = order.MatchConfirmed
+
+		updatedMatchB := order.EncodeMatch(match)
+		if err != nil {
+			return fmt.Errorf("error encoding match %x: %w", k, err)
+		}
+
+		return archivedMBkt.Put(matchKey, updatedMatchB)
+	})
+}
+
 func ensureVersion(tx *bbolt.Tx, ver uint32) error {
 	dbVersion, err := getVersionTx(tx)
 	if err != nil {