Skip to content

Commit f823dc4

Browse files
authored
enhancement: Adopt PEP 585 type hinting (part 3) (#2510)
* Update integs * Update filters.py
1 parent fed661d commit f823dc4

File tree

35 files changed

+262
-259
lines changed

35 files changed

+262
-259
lines changed

integrations/cometapi/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ module = [
8585
ignore_missing_imports = true
8686

8787
[tool.ruff]
88-
target-version = "py38"
88+
target-version = "py39"
8989
line-length = 120
9090

9191
[tool.ruff.lint]

integrations/cometapi/src/haystack_integrations/components/generators/cometapi/chat/chat_generator.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Any, Dict, List, Optional, Union
1+
from typing import Any, Optional, Union
22

33
from haystack.components.generators.chat import OpenAIChatGenerator
44
from haystack.dataclasses import StreamingCallbackT
@@ -35,12 +35,12 @@ def __init__(
3535
api_key: Secret = Secret.from_env_var("COMET_API_KEY"),
3636
model: str = "gpt-4o-mini",
3737
streaming_callback: Optional[StreamingCallbackT] = None,
38-
generation_kwargs: Optional[Dict[str, Any]] = None,
38+
generation_kwargs: Optional[dict[str, Any]] = None,
3939
timeout: Optional[int] = None,
4040
max_retries: Optional[int] = None,
41-
tools: Optional[Union[List[Union[Tool, Toolset]], Toolset]] = None,
41+
tools: Optional[Union[list[Union[Tool, Toolset]], Toolset]] = None,
4242
tools_strict: bool = False,
43-
http_client_kwargs: Optional[Dict[str, Any]] = None,
43+
http_client_kwargs: Optional[dict[str, Any]] = None,
4444
):
4545
api_base_url = "https://api.cometapi.com/v1"
4646

integrations/elasticsearch/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ disallow_incomplete_defs = true
8383
allow-direct-references = true
8484

8585
[tool.ruff]
86-
target-version = "py38"
86+
target-version = "py39"
8787
line-length = 120
8888

8989
[tool.ruff.lint]

integrations/elasticsearch/src/haystack_integrations/components/retrievers/elasticsearch/bm25_retriever.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# SPDX-FileCopyrightText: 2023-present deepset GmbH <[email protected]>
22
#
33
# SPDX-License-Identifier: Apache-2.0
4-
from typing import Any, Dict, List, Optional, Union
4+
from typing import Any, Optional, Union
55

66
from haystack import component, default_from_dict, default_to_dict
77
from haystack.dataclasses import Document
@@ -47,7 +47,7 @@ def __init__(
4747
self,
4848
*,
4949
document_store: ElasticsearchDocumentStore,
50-
filters: Optional[Dict[str, Any]] = None,
50+
filters: Optional[dict[str, Any]] = None,
5151
fuzziness: str = "AUTO",
5252
top_k: int = 10,
5353
scale_score: bool = False,
@@ -79,7 +79,7 @@ def __init__(
7979
self._scale_score = scale_score
8080
self._filter_policy = FilterPolicy.from_str(filter_policy) if isinstance(filter_policy, str) else filter_policy
8181

82-
def to_dict(self) -> Dict[str, Any]:
82+
def to_dict(self) -> dict[str, Any]:
8383
"""
8484
Serializes the component to a dictionary.
8585
@@ -97,7 +97,7 @@ def to_dict(self) -> Dict[str, Any]:
9797
)
9898

9999
@classmethod
100-
def from_dict(cls, data: Dict[str, Any]) -> "ElasticsearchBM25Retriever":
100+
def from_dict(cls, data: dict[str, Any]) -> "ElasticsearchBM25Retriever":
101101
"""
102102
Deserializes the component from a dictionary.
103103
@@ -115,10 +115,10 @@ def from_dict(cls, data: Dict[str, Any]) -> "ElasticsearchBM25Retriever":
115115
data["init_parameters"]["filter_policy"] = FilterPolicy.from_str(filter_policy)
116116
return default_from_dict(cls, data)
117117

118-
@component.output_types(documents=List[Document])
118+
@component.output_types(documents=list[Document])
119119
def run(
120-
self, query: str, filters: Optional[Dict[str, Any]] = None, top_k: Optional[int] = None
121-
) -> Dict[str, List[Document]]:
120+
self, query: str, filters: Optional[dict[str, Any]] = None, top_k: Optional[int] = None
121+
) -> dict[str, list[Document]]:
122122
"""
123123
Retrieve documents using the BM25 keyword-based algorithm.
124124
@@ -140,10 +140,10 @@ def run(
140140
)
141141
return {"documents": docs}
142142

143-
@component.output_types(documents=List[Document])
143+
@component.output_types(documents=list[Document])
144144
async def run_async(
145-
self, query: str, filters: Optional[Dict[str, Any]] = None, top_k: Optional[int] = None
146-
) -> Dict[str, List[Document]]:
145+
self, query: str, filters: Optional[dict[str, Any]] = None, top_k: Optional[int] = None
146+
) -> dict[str, list[Document]]:
147147
"""
148148
Asynchronously retrieve documents using the BM25 keyword-based algorithm.
149149

integrations/elasticsearch/src/haystack_integrations/components/retrievers/elasticsearch/embedding_retriever.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# SPDX-FileCopyrightText: 2023-present deepset GmbH <[email protected]>
22
#
33
# SPDX-License-Identifier: Apache-2.0
4-
from typing import Any, Dict, List, Optional, Union
4+
from typing import Any, Optional, Union
55

66
from haystack import component, default_from_dict, default_to_dict
77
from haystack.dataclasses import Document
@@ -49,7 +49,7 @@ def __init__(
4949
self,
5050
*,
5151
document_store: ElasticsearchDocumentStore,
52-
filters: Optional[Dict[str, Any]] = None,
52+
filters: Optional[dict[str, Any]] = None,
5353
top_k: int = 10,
5454
num_candidates: Optional[int] = None,
5555
filter_policy: Union[str, FilterPolicy] = FilterPolicy.REPLACE,
@@ -78,7 +78,7 @@ def __init__(
7878
self._num_candidates = num_candidates
7979
self._filter_policy = FilterPolicy.from_str(filter_policy) if isinstance(filter_policy, str) else filter_policy
8080

81-
def to_dict(self) -> Dict[str, Any]:
81+
def to_dict(self) -> dict[str, Any]:
8282
"""
8383
Serializes the component to a dictionary.
8484
@@ -95,7 +95,7 @@ def to_dict(self) -> Dict[str, Any]:
9595
)
9696

9797
@classmethod
98-
def from_dict(cls, data: Dict[str, Any]) -> "ElasticsearchEmbeddingRetriever":
98+
def from_dict(cls, data: dict[str, Any]) -> "ElasticsearchEmbeddingRetriever":
9999
"""
100100
Deserializes the component from a dictionary.
101101
@@ -113,10 +113,10 @@ def from_dict(cls, data: Dict[str, Any]) -> "ElasticsearchEmbeddingRetriever":
113113
data["init_parameters"]["filter_policy"] = FilterPolicy.from_str(filter_policy)
114114
return default_from_dict(cls, data)
115115

116-
@component.output_types(documents=List[Document])
116+
@component.output_types(documents=list[Document])
117117
def run(
118-
self, query_embedding: List[float], filters: Optional[Dict[str, Any]] = None, top_k: Optional[int] = None
119-
) -> Dict[str, List[Document]]:
118+
self, query_embedding: list[float], filters: Optional[dict[str, Any]] = None, top_k: Optional[int] = None
119+
) -> dict[str, list[Document]]:
120120
"""
121121
Retrieve documents using a vector similarity metric.
122122
@@ -138,10 +138,10 @@ def run(
138138
)
139139
return {"documents": docs}
140140

141-
@component.output_types(documents=List[Document])
141+
@component.output_types(documents=list[Document])
142142
async def run_async(
143-
self, query_embedding: List[float], filters: Optional[Dict[str, Any]] = None, top_k: Optional[int] = None
144-
) -> Dict[str, List[Document]]:
143+
self, query_embedding: list[float], filters: Optional[dict[str, Any]] = None, top_k: Optional[int] = None
144+
) -> dict[str, list[Document]]:
145145
"""
146146
Asynchronously retrieve documents using a vector similarity metric.
147147

0 commit comments

Comments
 (0)