template tags pollutes global context with 'object'

[benzkji]

I had a hard time debugging a project where this library was used. The problem is, that the {% snippet_fragment 'whatever' %} overrides the object of the current context. This is not as it should be...in my case, introducing a snippet in a detail view caused the main object of my detail view to change.

cms 3.11.1 snippet 3.1.0 django 3.2.16

[fsbraun]

I'd assume that the snippet_fragment will not need access to the context, or will it? If not it can be solved by providing the template tag with its own context replacing context.update:

djangocms-snippet/djangocms_snippet/templatetags/snippet_tags.py

Lines 84 to 100 in b53f675

	context.update({
	'object': instance,
	})
	try:
	if instance.template:
	context.update({
	'html': mark_safe(instance.html)
	})
	content = template.loader.render_to_string(
	instance.template,
	context.flatten(),
	)
	else:
	t = template.Template(instance.html)
	content = t.render(context)
	except template.TemplateDoesNotExist:
	content = _('Template %(template)s does not exist.') % {

[benzkji]

It may be the case that some people use it this way - the way I dont want/need it: using context from "outside", in the snippet, so changing this might breakt their projects.. ;-) Alternative solutions could be: Clone the context (not very efficient, probably!), or use a different name for the snippet object in the context ('snippet'?).

I've not used djangocms-snippet before, so I'm no big help of how people use it. There is one closed issue, though, and how I can feel there, it should work as we two think. see #38

[fsbraun]

If this is a potential use case the solution probably involves "popping" the updated context after rendering the content: context.pop() to uncover the old object context.

    context.update({'object': instance})
    # render here
    context.pop()  # uncover old object instance

Just one has to be aware that there are multiple updates.

[benzkji]

Yeah, that would do it!