Updated tests and removed more refrences to the old tests

have also added migrations

Author: CaptainJack2491

accounts/forms.py

@@ -64,13 +64,6 @@ def clean(self):
             raise forms.ValidationError(_("Staff users cannot be deleted"))
         return cleaned_data
 
-    def add_errors_from_protectederror(self, exception):
-        """
-        Convert the given ProtectedError exception object into validation
-        errors on the instance.
-        """
-        self.add_error(None, _("User has protected data and cannot be deleted"))
-
     @transaction.atomic()
     def delete(self):
         """

accounts/tests.py

@@ -218,17 +218,6 @@ def test_deletion_staff_forbidden(self):
         form = self.create_user_and_form(is_staff=True)
         self.assertFormError(form, None, ["Staff users cannot be deleted"])
 
-    def test_user_with_protected_data(self):
-        form = self.create_user_and_form()
-        form.user.boardmember_set.create(
-            office=foundationmodels.Office.objects.create(name="test"),
-            term=foundationmodels.Term.objects.create(year=2000),
-        )
-        form.delete()
-        self.assertFormError(
-            form, None, ["User has protected data and cannot be deleted"]
-        )
-
     def test_form_delete_method_requires_valid_form(self):
         form = self.create_user_and_form(is_staff=True)
         self.assertRaises(form.InvalidFormError, form.delete)

foundation/admin.py

@@ -1,5 +1,4 @@
 from django.contrib import admin
-from django.utils.text import slugify
 from django.utils.translation import gettext as _
 
 from . import models

foundation/migrations/0008_remove_approvedcorporatemember_approved_at_and_more.py

@@ -0,0 +1,83 @@
+# Generated by Django 5.2 on 2025-09-23 05:51
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('foundation', '0007_boardmember_account_protect'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='approvedcorporatemember',
+            name='approved_at',
+        ),
+        migrations.RemoveField(
+            model_name='approvedgrant',
+            name='approved_at',
+        ),
+        migrations.RemoveField(
+            model_name='approvedindividualmember',
+            name='approved_at',
+        ),
+        migrations.RemoveField(
+            model_name='boardmember',
+            name='account',
+        ),
+        migrations.RemoveField(
+            model_name='boardmember',
+            name='office',
+        ),
+        migrations.RemoveField(
+            model_name='boardmember',
+            name='term',
+        ),
+        migrations.RemoveField(
+            model_name='meeting',
+            name='board_attendees',
+        ),
+        migrations.RemoveField(
+            model_name='meeting',
+            name='leader',
+        ),
+        migrations.RemoveField(
+            model_name='business',
+            name='meeting',
+        ),
+        migrations.RemoveField(
+            model_name='meeting',
+            name='non_board_attendees',
+        ),
+        migrations.DeleteModel(
+            name='ActionItem',
+        ),
+        migrations.DeleteModel(
+            name='ApprovedCorporateMember',
+        ),
+        migrations.DeleteModel(
+            name='ApprovedGrant',
+        ),
+        migrations.DeleteModel(
+            name='ApprovedIndividualMember',
+        ),
+        migrations.DeleteModel(
+            name='Office',
+        ),
+        migrations.DeleteModel(
+            name='Term',
+        ),
+        migrations.DeleteModel(
+            name='BoardMember',
+        ),
+        migrations.DeleteModel(
+            name='Business',
+        ),
+        migrations.DeleteModel(
+            name='Meeting',
+        ),
+        migrations.DeleteModel(
+            name='NonBoardAttendee',
+        ),
+    ]

foundation/models.py

@@ -1,16 +1,5 @@
-from decimal import Decimal
-
-from django.conf import settings
 from django.db import models
-from django.urls import reverse
-from django.utils.dateformat import format as date_format
 from django.utils.translation import gettext_lazy as _
-from djmoney.models.fields import MoneyField
-from djmoney.settings import CURRENCIES
-from docutils.core import publish_parts
-
-from blog.models import BLOG_DOCUTILS_SETTINGS
-
 
 class CoreAwardCohort(models.Model):
     """

foundation/tests.py

@@ -1,4 +1,6 @@
 from django.contrib.auth.models import User
+from django.contrib.flatpages.models import FlatPage
+from django.contrib.sites.models import Site
 from django.test import TestCase
 
 class MeetingTestCase(TestCase):
@@ -7,21 +9,17 @@ def setUpTestData(cls):
         cls.user = User.objects.create_superuser(
             "admin", "[email protected]", "password"
         )
+        cls.site = Site.objects.get_current()
 
     def test_latest_meeting_minutes(self):
-        pass
-
-        # TODO: Find a way to initalize the foundation page without using the Meeting
-        # object
+        page = FlatPage.objects.create(
+            title="Foundation",
+            url="/foundation/",
+            template_name="flatpages/foundation.html"
+        )
+        page.sites.add(self.site)
 
-        common_meeting_data = {
-            "slug": "dsf-board-monthly-meeting",
-            "leader": self.member,
-            "treasurer_report": "Hello World",
-            "title": "DSF Board monthly meeting",
-        }
-        Meeting.objects.create(date=date(2023, 3, 12), **common_meeting_data)
-        response = self.client.get(reverse("foundation_meeting_archive_index"))
+        response = self.client.get("/foundation/")
 
         self.assertContains(response, "Latest DSF meeting minutes")
         self.assertContains(response, "https://github.com/django/dsf-minutes")