The expressionsem file have a code smell.

[12345swordy]

It is literally over 10k lines of code, the majority of it consist of function overloading for different classes. Why can't there be files for every class that has functions being overloaded?

[UplinkCoder]

Because that doesn't make anything cleaner it just spreads it around the filesystem. Am Fr., 17. Sept. 2021 um 21:18 Uhr schrieb 12345swordy < ***@***.***>:

…

It is literally over 10k lines of code, the majority of it consist of function overloading for different classes. Why can't there be files for every class that has functions being overloaded? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#13080>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVWSCAEN3GWHRGO7ZR55H3UCOH6ZANCNFSM5EIFYWGA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[12345swordy]

Surely, you have better ideas then the current status quo? There is now semantic analysis for import C in the expressionsem file now, which is not obvious to anyone who is new to the compiler internals.

[maxhaton]

Breaking it up into files requires sensible places for the files to go (packages) and that did not end well last time or the time before that or the time before that or the time before that etc. etc..

The current file-osophy is akin to filling a big tray of shot glasses with a garden hose - you fill up the ones you aim for but the fluid still spills all over the place e.g.templateInstanceSemantic is buried in the middle of nowhere in dsymbolsem IIRC. It could be worse in that this is somewhat preferable to "Enterprise" code which actively hides the interesting stuff, but even GCC is downright poetry compared to us in some ways and GCC has way more baggage and a vastly inferior emergent-language (due to C -> C++11 transition it's still somewhat in between the two)