Fix review comments for PR microsoft#637

- Add validation that --no-bom requires -u (Unicode output file)
- Add test case for --no-bom validation

Author: dlevy-msft-sql

cmd/sqlcmd/sqlcmd.go

@@ -172,6 +172,8 @@ func (a *SQLCmdArguments) Validate(c *cobra.Command) (err error) {
 			err = rangeParameterError("-t", fmt.Sprint(a.QueryTimeout), 0, 65534, true)
 		case a.ServerCertificate != "" && !encryptConnectionAllowsTLS(a.EncryptConnection):
 			err = localizer.Errorf("The -J parameter requires encryption to be enabled (-N true, -N mandatory, or -N strict).")
+		case a.NoBOM && !a.UnicodeOutputFile:
+			err = localizer.Errorf("The --no-bom parameter requires -u (Unicode output file).")
 		}
 	}
 	if err != nil {

cmd/sqlcmd/sqlcmd_test.go

@@ -220,6 +220,7 @@ func TestValidateFlags(t *testing.T) {
 		{[]string{"-a", "100"}, "'-a 100': Packet size has to be a number between 512 and 32767."},
 		{[]string{"-h-4"}, "'-h -4': header value must be either -1 or a value between 1 and 2147483647"},
 		{[]string{"-w", "6"}, "'-w 6': value must be greater than 8 and less than 65536."},
+		{[]string{"--no-bom"}, "The --no-bom parameter requires -u (Unicode output file)."},
 	}
 
 	for _, test := range commands {