Move hardcoded cli strings to resx (#10504)

* Move hardcoded cli strings to resx

* update names

* update designers

Author: adamint

src/Aspire.Cli/Commands/ExecCommand.cs

@@ -199,7 +199,7 @@ protected override async Task<int> ExecuteAsync(ParseResult parseResult, Cancell
                     });
 
                 commandExitCode = await _interactionService.ShowStatusAsync<int?>(
-                    ":running_shoe: Running exec...",
+                    $":running_shoe: {ExecCommandStrings.Running}",
                     async () =>
                     {
                         // execute tool and stream the output
@@ -222,7 +222,7 @@ protected override async Task<int> ExecuteAsync(ParseResult parseResult, Cancell
                 if (backchannel is not null)
                 {
                     _ = await _interactionService.ShowStatusAsync<int>(
-                    ":linked_paperclips: Stopping app host...",
+                    $":linked_paperclips: {ExecCommandStrings.StoppingAppHost}",
                     async () =>
                     {
                         await backchannel.RequestStopAsync(cancellationToken);

src/Aspire.Cli/Commands/RunCommand.cs

@@ -158,7 +158,7 @@ protected override async Task<int> ExecuteAsync(ParseResult parseResult, Cancell
                 cancellationToken);
 
             // Wait for the backchannel to be established.
-            var backchannel = await _interactionService.ShowStatusAsync("Connecting to app host...", async () =>
+            var backchannel = await _interactionService.ShowStatusAsync(RunCommandStrings.ConnectingToAppHost, async () =>
             {
                 return await backchannelCompletitionSource.Task.WaitAsync(cancellationToken);
             });
@@ -167,7 +167,7 @@ protected override async Task<int> ExecuteAsync(ParseResult parseResult, Cancell
 
             var pendingLogCapture = CaptureAppHostLogsAsync(logFile, backchannel, cancellationToken);
 
-            var dashboardUrls = await _interactionService.ShowStatusAsync("Starting dashboard...", async () =>
+            var dashboardUrls = await _interactionService.ShowStatusAsync(RunCommandStrings.StartingDashboard, async () =>
             {
                 return await backchannel.GetDashboardUrlsAsync(cancellationToken);
             });

src/Aspire.Cli/Interaction/ConsoleInteractionService.cs

@@ -194,8 +194,8 @@ public void DisplayEmptyLine()
     public void DisplayVersionUpdateNotification(string newerVersion)
     {
         _ansiConsole.WriteLine();
-        _ansiConsole.MarkupLine($"[yellow]A new version of the Aspire CLI is available: {newerVersion}[/]");
-        _ansiConsole.MarkupLine($"[dim]For more information, see: [link]{UpdateUrl}[/][/]");
+        _ansiConsole.MarkupLine(string.Format(CultureInfo.CurrentCulture, InteractionServiceStrings.NewCliVersionAvailable, newerVersion));
+        _ansiConsole.MarkupLine(string.Format(CultureInfo.CurrentCulture, InteractionServiceStrings.MoreInfoNewCliVersion, UpdateUrl));
         _ansiConsole.WriteLine();
     }
 }

src/Aspire.Cli/Resources/ExecCommandStrings.Designer.cs

@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
-  <!-- 
-    Microsoft ResX Schema 
-    
+  <!--
+    Microsoft ResX Schema
+
     Version 2.0
-    
-    The primary goals of this format is to allow a simple XML format 
-    that is mostly human readable. The generation and parsing of the 
-    various data types are done through the TypeConverter classes 
+
+    The primary goals of this format is to allow a simple XML format
+    that is mostly human readable. The generation and parsing of the
+    various data types are done through the TypeConverter classes
     associated with the data types.
-    
+
     Example:
-    
+
     ... ado.net/XML headers & schema ...
     <resheader name="resmimetype">text/microsoft-resx</resheader>
     <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
         <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
-                
-    There are any number of "resheader" rows that contain simple 
+
+    There are any number of "resheader" rows that contain simple
     name/value pairs.
-    
-    Each data row contains a name, and value. The row also contains a 
-    type or mimetype. Type corresponds to a .NET class that support 
-    text/value conversion through the TypeConverter architecture. 
-    Classes that don't support this are serialized and stored with the 
+
+    Each data row contains a name, and value. The row also contains a
+    type or mimetype. Type corresponds to a .NET class that support
+    text/value conversion through the TypeConverter architecture.
+    Classes that don't support this are serialized and stored with the
     mimetype set.
-    
-    The mimetype is used for serialized objects, and tells the 
-    ResXResourceReader how to depersist the object. This is currently not 
+
+    The mimetype is used for serialized objects, and tells the
+    ResXResourceReader how to depersist the object. This is currently not
     extensible. For a given mimetype the value must be set accordingly:
-    
-    Note - application/x-microsoft.net.object.binary.base64 is the format 
-    that the ResXResourceWriter will generate, however the reader can 
+
+    Note - application/x-microsoft.net.object.binary.base64 is the format
+    that the ResXResourceWriter will generate, however the reader can
     read any of the formats listed below.
-    
+
     mimetype: application/x-microsoft.net.object.binary.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
             : and then encoded with base64 encoding.
-    
+
     mimetype: application/x-microsoft.net.object.soap.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
             : and then encoded with base64 encoding.
 
     mimetype: application/x-microsoft.net.object.bytearray.base64
-    value   : The object must be serialized into a byte array 
+    value   : The object must be serialized into a byte array
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
@@ -147,4 +147,10 @@ Examples:
   <data name="NoCommandSpecified" xml:space="preserve">
     <value>Command is not specified.</value>
   </data>
-</root>
+  <data name="Running" xml:space="preserve">
+    <value>Running exec...</value>
+  </data>
+  <data name="StoppingAppHost" xml:space="preserve">
+    <value>Stopping app host...</value>
+  </data>
+</root>

src/Aspire.Cli/Resources/ExecCommandStrings.resx

@@ -200,4 +200,12 @@
   <data name="WaitingForDebuggerToAttachToAppHost" xml:space="preserve">
     <value>Waiting for debugger to attach to app host process</value>
   </data>
+  <data name="NewCliVersionAvailable" xml:space="preserve">
+    <value>[yellow]A new version of the Aspire CLI is available: {0}[/]</value>
+    <comment>Do not translate [yellow] and also leave [/] as-is. {0} is the version number</comment>
+  </data>
+  <data name="MoreInfoNewCliVersion" xml:space="preserve">
+    <value>[dim]For more information, see: [link]{0}[/][/]</value>
+    <comment>Do not translate [dim] and [link]. Also leave [/] as-is. {0} is a URL</comment>
+  </data>
 </root>