Skip to content

Commit 3969687

Browse files
authored
[release/8.0] Use wait assert in flaky tests (#63565)
* Make the flaky test wait for the conditon to be true. * Improve `NavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServerAndWebAssembly` * Add quarantine to the failing test.
1 parent 748205c commit 3969687

File tree

3 files changed

+19
-10
lines changed

3 files changed

+19
-10
lines changed

src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -526,13 +526,21 @@ public void NavigationManagerUriGetsUpdatedOnEnhancedNavigation_BothServerAndWeb
526526

527527
Browser.Exists(By.TagName("nav")).FindElement(By.LinkText("LocationChanged/LocationChanging event (server-and-wasm)")).Click();
528528
Browser.Equal("Page with location changed components", () => Browser.Exists(By.TagName("h1")).Text);
529-
Assert.EndsWith("/nav/location-changed/server-and-wasm", Browser.Exists(By.Id("nav-uri-server")).Text);
530-
Assert.EndsWith("/nav/location-changed/server-and-wasm", Browser.Exists(By.Id("nav-uri-wasm")).Text);
529+
Browser.True(() => Browser.Exists(By.Id("nav-uri-server")).Text.EndsWith(
530+
"/nav/location-changed/server-and-wasm",
531+
StringComparison.Ordinal));
532+
Browser.True(() => Browser.Exists(By.Id("nav-uri-wasm")).Text.EndsWith(
533+
"/nav/location-changed/server-and-wasm",
534+
StringComparison.Ordinal));
531535

532536
Browser.Exists(By.Id($"update-query-string-{runtimeThatInvokedNavigation}")).Click();
533537

534-
Assert.EndsWith($"/nav/location-changed/server-and-wasm?query=1", Browser.Exists(By.Id($"nav-uri-server")).Text);
535-
Assert.EndsWith($"/nav/location-changed/server-and-wasm?query=1", Browser.Exists(By.Id($"nav-uri-wasm")).Text);
538+
Browser.True(() => Browser.Exists(By.Id("nav-uri-server")).Text.EndsWith(
539+
"/nav/location-changed/server-and-wasm?query=1",
540+
StringComparison.Ordinal));
541+
Browser.True(() => Browser.Exists(By.Id("nav-uri-wasm")).Text.EndsWith(
542+
"/nav/location-changed/server-and-wasm?query=1",
543+
StringComparison.Ordinal));
536544
}
537545

538546
[Theory]

src/Components/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1344,19 +1344,19 @@ public void RadioButtonGetsResetAfterSubmittingEnhancedForm()
13441344
{
13451345
GoTo("forms/form-with-checkbox-and-radio-button");
13461346

1347-
Assert.False(Browser.Exists(By.Id("checkbox")).Selected);
1348-
Assert.False(Browser.Exists(By.Id("radio-button")).Selected);
1347+
WaitAssert.False(Browser, () => Browser.Exists(By.Id("checkbox")).Selected);
1348+
WaitAssert.False(Browser, () => Browser.Exists(By.Id("radio-button")).Selected);
13491349

13501350
Browser.Exists(By.Id("checkbox")).Click();
13511351
Browser.Exists(By.Id("radio-button")).Click();
13521352

1353-
Assert.True(Browser.Exists(By.Id("checkbox")).Selected);
1354-
Assert.True(Browser.Exists(By.Id("radio-button")).Selected);
1353+
WaitAssert.True(Browser, () => Browser.Exists(By.Id("checkbox")).Selected);
1354+
WaitAssert.True(Browser, () => Browser.Exists(By.Id("radio-button")).Selected);
13551355

13561356
Browser.Exists(By.Id("submit-button")).Click();
13571357

1358-
Assert.False(Browser.Exists(By.Id("checkbox")).Selected);
1359-
Assert.False(Browser.Exists(By.Id("radio-button")).Selected);
1358+
WaitAssert.False(Browser, () => Browser.Exists(By.Id("checkbox")).Selected);
1359+
WaitAssert.False(Browser, () => Browser.Exists(By.Id("radio-button")).Selected);
13601360
}
13611361

13621362
[Fact]

src/SignalR/server/StackExchangeRedis/test/RedisEndToEnd.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ public async Task HubConnectionCanSendAndReceiveGroupMessagesGroupNameWithPatter
184184
[ConditionalTheory]
185185
[SkipIfDockerNotPresent]
186186
[MemberData(nameof(TransportTypesAndProtocolTypes))]
187+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/63582")]
187188
public async Task CanSendAndReceiveUserMessagesUserNameWithPatternIsTreatedAsLiteral(HttpTransportType transportType, string protocolName)
188189
{
189190
using (StartVerifiableLog())

0 commit comments

Comments
 (0)