Quarantine RunAsync_WaitsForCompletion_Single_RegistrationParameters

[captainsafia]

Failing Test(s)

• Microsoft.Extensions.Diagnostics.HealthChecks.HealthCheckPublisherHostedServiceTest.RunAsync_WaitsForCompletion_Single_RegistrationParameters

Error Message

Assert.Contains() Failure
Not found: CheckDelay1Period9
In value:  String[] ["CheckDefault", "CheckDelay1Period18", "CheckDelay2Period18"]

Stacktrace

   at Microsoft.Extensions.Diagnostics.HealthChecks.HealthCheckPublisherHostedServiceTest.RunAsync_WaitsForCompletion_Single_RegistrationParameters() in /_/src/HealthChecks/HealthChecks/test/HealthCheckPublisherHostedServiceTest.cs:line 388
--- End of stack trace from previous location ---

Logs

Build

• https://dev.azure.com/dnceng-public/public/_build/results?buildId=356938&view=ms.vss-test-web.build-test-results-tab&runId=7511354&resultId=122241&paneView=debug

[feherzsolt]

Hi,
I have spent some time investigating this and in my opinion the issue is a race condition with the TestPublisher here. My observation is the flaky test is writing mulitple reports from multiple timer at around the same time. In my opinion the fix would be easy, using a thread safe collection. Do you think this worth pursuing? ( I can implement this modification. )

[feherzsolt]

In my opinion the same applies to #56245

[captainsafia]

@feherzsolt That seems like a reasonable thing to try. We can see if using a concurrent collection improves things here.