diff --git a/dotnet/targets/Xamarin.Shared.Sdk.targets b/dotnet/targets/Xamarin.Shared.Sdk.targets index fc5651e91e97..ecc868832527 100644 --- a/dotnet/targets/Xamarin.Shared.Sdk.targets +++ b/dotnet/targets/Xamarin.Shared.Sdk.targets @@ -1901,7 +1901,6 @@ @@ -1922,9 +1921,8 @@ @@ -2234,8 +2232,7 @@ - [18.1.4-g269e166fc3] + [18.1.48-g89254113ea] diff --git a/msbuild/Xamarin.MacDev.Tasks/Tasks/WriteItemsToFile.cs b/msbuild/Xamarin.MacDev.Tasks/Tasks/WriteItemsToFile.cs index 912a61b25984..e2988f41b671 100644 --- a/msbuild/Xamarin.MacDev.Tasks/Tasks/WriteItemsToFile.cs +++ b/msbuild/Xamarin.MacDev.Tasks/Tasks/WriteItemsToFile.cs @@ -8,10 +8,8 @@ using Microsoft.Build.Tasks; using System.Xml.Linq; -using Xamarin.Messaging.Build.Client; - namespace Xamarin.MacDev.Tasks { - public class WriteItemsToFile : XamarinTask, ICancelableTask { + public class WriteItemsToFile : XamarinTask { static readonly XNamespace XmlNs = XNamespace.Get ("http://schemas.microsoft.com/developer/msbuild/2003"); static readonly XName ProjectElementName = XmlNs + "Project"; @@ -36,9 +34,6 @@ public class WriteItemsToFile : XamarinTask, ICancelableTask { public override bool Execute () { - if (ShouldExecuteRemotely ()) - return ExecuteRemotely (); - Write (this, File?.ItemSpec, Items, ItemName, Overwrite, IncludeMetadata); return true; } @@ -83,11 +78,5 @@ static IEnumerable CreateMetadataFromItem (ITaskItem item, bool includ return Enumerable.Empty (); } - - public void Cancel () - { - if (ShouldExecuteRemotely ()) - BuildConnection.CancelAsync (BuildEngine4).Wait (); - } } } diff --git a/msbuild/Xamarin.Shared/Xamarin.Mac.AppExtension.Common.targets b/msbuild/Xamarin.Shared/Xamarin.Mac.AppExtension.Common.targets index 569a2dbac1d9..7e7fb0796862 100644 --- a/msbuild/Xamarin.Shared/Xamarin.Mac.AppExtension.Common.targets +++ b/msbuild/Xamarin.Shared/Xamarin.Mac.AppExtension.Common.targets @@ -25,17 +25,6 @@ Copyright (C) 2013-2014 Xamarin. All rights reserved. - - - - - - - - - Entitlements.plist - - diff --git a/msbuild/Xamarin.Shared/Xamarin.Shared.targets b/msbuild/Xamarin.Shared/Xamarin.Shared.targets index 540343f7d0a2..ca19c2aef7c4 100644 --- a/msbuild/Xamarin.Shared/Xamarin.Shared.targets +++ b/msbuild/Xamarin.Shared/Xamarin.Shared.targets @@ -120,7 +120,7 @@ Copyright (C) 2018 Microsoft. All rights reserved. - False + False @@ -372,7 +372,7 @@ Copyright (C) 2018 Microsoft. All rights reserved. - + @@ -405,9 +405,9 @@ Copyright (C) 2018 Microsoft. All rights reserved. <_IpaPackageFile Include="$(DeviceSpecificOutputPath)*.ipa" /> - - - + + + @@ -2530,8 +2530,6 @@ Copyright (C) 2018 Microsoft. All rights reserved. > + + + + true - + @@ -2731,6 +2731,7 @@ Copyright (C) 2018 Microsoft. All rights reserved. @@ -2997,7 +2998,7 @@ Copyright (C) 2018 Microsoft. All rights reserved. > - - - - - diff --git a/msbuild/Xamarin.Shared/Xamarin.iOS.AppExtension.Common.targets b/msbuild/Xamarin.Shared/Xamarin.iOS.AppExtension.Common.targets index 2c2584b6b595..67cd4bfe4602 100644 --- a/msbuild/Xamarin.Shared/Xamarin.iOS.AppExtension.Common.targets +++ b/msbuild/Xamarin.Shared/Xamarin.iOS.AppExtension.Common.targets @@ -26,11 +26,6 @@ Copyright (C) 2014-2016 Xamarin. All rights reserved. - - - - - diff --git a/msbuild/Xamarin.Shared/Xamarin.iOS.Common.targets b/msbuild/Xamarin.Shared/Xamarin.iOS.Common.targets index e41b93ce7ac5..804a66334bbf 100644 --- a/msbuild/Xamarin.Shared/Xamarin.iOS.Common.targets +++ b/msbuild/Xamarin.Shared/Xamarin.iOS.Common.targets @@ -235,7 +235,7 @@ Copyright (C) 2013-2016 Xamarin. All rights reserved. diff --git a/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.Messaging.Apple.targets b/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.Messaging.Apple.targets index af7c6b398843..1c4fc93356b4 100644 --- a/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.Messaging.Apple.targets +++ b/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.Messaging.Apple.targets @@ -20,7 +20,7 @@ True - False + False diff --git a/tests/dotnet/UnitTests/ProjectTest.cs b/tests/dotnet/UnitTests/ProjectTest.cs index 2a413dce6b42..518bca5075ec 100644 --- a/tests/dotnet/UnitTests/ProjectTest.cs +++ b/tests/dotnet/UnitTests/ProjectTest.cs @@ -1853,6 +1853,19 @@ public void KillEverything () [TestCase (ApplePlatform.MacOSX, "osx-x64;osx-arm64", true)] // [TestCase ("MacCatalyst", "")] - No extension support yet public void BuildProjectsWithExtensions (ApplePlatform platform, string runtimeIdentifier, bool isNativeAot) + { + BuildProjectsWithExtensionsImpl (platform, runtimeIdentifier, isNativeAot); + } + + [TestCase (ApplePlatform.iOS, "ios-arm64", false)] + [Category ("RemoteWindows")] + public void BuildProjectsWithExtensionsOnRemoteWindows (ApplePlatform platform, string runtimeIdentifier, bool isNativeAot) + { + Configuration.IgnoreIfNotOnWindows (); + BuildProjectsWithExtensionsImpl (platform, runtimeIdentifier, isNativeAot, AddRemoteProperties ()); + } + + void BuildProjectsWithExtensionsImpl (ApplePlatform platform, string runtimeIdentifier, bool isNativeAot, Dictionary? properties = null) { Configuration.IgnoreIfIgnoredPlatform (platform); var consumingProjectDir = GetProjectPath ("ExtensionConsumer", runtimeIdentifier, platform, out var appPath); @@ -1861,7 +1874,7 @@ public void BuildProjectsWithExtensions (ApplePlatform platform, string runtimeI Clean (extensionProjectDir); Clean (consumingProjectDir); - var properties = GetDefaultProperties (runtimeIdentifier); + properties = GetDefaultProperties (runtimeIdentifier, extraProperties: properties); if (isNativeAot) { properties ["PublishAot"] = "true"; diff --git a/tools/devops/automation/scripts/run-remote-windows-tests.ps1 b/tools/devops/automation/scripts/run-remote-windows-tests.ps1 index accd36149a93..4181e1564542 100644 --- a/tools/devops/automation/scripts/run-remote-windows-tests.ps1 +++ b/tools/devops/automation/scripts/run-remote-windows-tests.ps1 @@ -26,3 +26,5 @@ if ("$Env:TESTFILTER" -eq "") { "--logger:trx;LogFileName=$Env:BUILD_SOURCESDIRECTORY/$Env:BUILD_REPOSITORY_TITLE/jenkins-results/windows-remote-dotnet-tests.trx" ` "--logger:html;LogFileName=$Env:BUILD_SOURCESDIRECTORY/$Env:BUILD_REPOSITORY_TITLE/jenkins-results/windows-remote-dotnet-tests.html" ` "-bl:$Env:BUILD_SOURCESDIRECTORY/$Env:BUILD_REPOSITORY_TITLE/tests/dotnet/Windows/windows-remote-dotnet-tests.binlog" + +exit $LASTEXITCODE