Merge pull request #9825 from tmat/RemovePing

Remove SendPingMessage

Author: drewnoakes

src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/HotReload/Contracts/AbstractBrowserRefreshServerAccessor.cs

@@ -22,9 +22,6 @@ public void ConfigureLaunchEnvironment(IDictionary<string, string> builder, bool
     public ValueTask RefreshBrowserAsync(CancellationToken cancellationToken)
         => Server.RefreshBrowserAsync(cancellationToken);
 
-    public ValueTask SendPingMessageAsync(CancellationToken cancellationToken)
-        => Server.SendPingMessageAsync(cancellationToken);
-
     public ValueTask SendReloadMessageAsync(CancellationToken cancellationToken)
         => Server.SendReloadMessageAsync(cancellationToken);
 

src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/HotReload/Contracts/IBrowserRefreshService.cs

@@ -19,7 +19,6 @@ public interface IBrowserRefreshService
     /// It is safe to call this multiple times.
     /// </summary>
     /// <param name="cancellationToken"></param>
-    /// <returns></returns>
     ValueTask StartServerAsync(CancellationToken cancellationToken);
 
     /// <summary>
@@ -34,18 +33,10 @@ public interface IBrowserRefreshService
     /// </summary>
     ValueTask RefreshBrowserAsync(CancellationToken cancellationToken);
 
-    /// <summary>
-    /// Sends a ping message to all connected browsers.
-    /// It will throw InvalidOperationException if the browser refresh server is not started.
-    /// </summary>
-    /// <param name="cancellationToken"></param>
-    ValueTask SendPingMessageAsync(CancellationToken cancellationToken);
-
     /// <summary>
     /// Sends a reload message to all connected browsers.
     /// It will throw InvalidOperationException if the browser refresh server is not started.
     /// </summary>
-    /// <returns></returns>
     ValueTask SendReloadMessageAsync(CancellationToken cancellationToken);
 
     /// <summary>

src/Microsoft.VisualStudio.ProjectSystem.Managed/PublicAPI/net472/PublicAPI.Shipped.txt

@@ -228,7 +228,6 @@ Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAcces
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.ConfigureLaunchEnvironment(System.Collections.Generic.IDictionary<string!, string!>! builder, bool enableHotReload) -> void
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.Dispose() -> void
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.RefreshBrowserAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
-Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.SendPingMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.SendReloadMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.SendWaitMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.StartServerAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
@@ -242,7 +241,6 @@ Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.BrowserLinkInjected.get -> bool
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.ConfigureLaunchEnvironmentAsync(System.Collections.Generic.IDictionary<string!, string!>! builder, bool enableHotReload, System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.RefreshBrowserAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
-Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.SendPingMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.SendReloadMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.SendWaitMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.StartServerAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask

src/Microsoft.VisualStudio.ProjectSystem.Managed/PublicAPI/net9.0/PublicAPI.Shipped.txt

@@ -222,7 +222,6 @@ Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAcces
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.ConfigureLaunchEnvironment(System.Collections.Generic.IDictionary<string, string> builder, bool enableHotReload) -> void
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.Dispose() -> void
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.RefreshBrowserAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
-Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.SendPingMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.SendReloadMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.SendWaitMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.AbstractBrowserRefreshServerAccessor.StartServerAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
@@ -236,7 +235,6 @@ Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.BrowserLinkInjected.get -> bool
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.ConfigureLaunchEnvironmentAsync(System.Collections.Generic.IDictionary<string, string> builder, bool enableHotReload, System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.RefreshBrowserAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
-Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.SendPingMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.SendReloadMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.SendWaitMessageAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask
 Microsoft.VisualStudio.ProjectSystem.HotReload.IBrowserRefreshService.StartServerAsync(System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask