Use new compiler API

Author: DoctorKrolic

src/Analyzers/CSharp/CodeFixes/MakeMethodAsynchronous/CSharpMakeMethodAsynchronousCodeFixProvider.cs

@@ -71,13 +71,12 @@ protected override SyntaxNode AddAsyncTokenAndFixReturnType(
         bool keepVoid,
         IMethodSymbol methodSymbol,
         SyntaxNode node,
-        KnownTaskTypes knownTypes,
-        CancellationToken cancellationToken)
+        KnownTaskTypes knownTypes)
     {
         return node switch
         {
-            MethodDeclarationSyntax method => FixMethod(keepVoid, methodSymbol, method, knownTypes, cancellationToken),
-            LocalFunctionStatementSyntax localFunction => FixLocalFunction(keepVoid, methodSymbol, localFunction, knownTypes, cancellationToken),
+            MethodDeclarationSyntax method => FixMethod(keepVoid, methodSymbol, method, knownTypes),
+            LocalFunctionStatementSyntax localFunction => FixLocalFunction(keepVoid, methodSymbol, localFunction, knownTypes),
             AnonymousFunctionExpressionSyntax anonymous => FixAnonymousFunction(anonymous),
             _ => node,
         };
@@ -87,34 +86,31 @@ private static MethodDeclarationSyntax FixMethod(
         bool keepVoid,
         IMethodSymbol methodSymbol,
         MethodDeclarationSyntax method,
-        KnownTaskTypes knownTypes,
-        CancellationToken cancellationToken)
+        KnownTaskTypes knownTypes)
     {
         var (newModifiers, newReturnType) = AddAsyncModifierWithCorrectedTrivia(
             method.Modifiers,
-            FixMethodReturnType(keepVoid, methodSymbol, method.ReturnType, knownTypes, cancellationToken));
+            FixMethodReturnType(keepVoid, methodSymbol, method.ReturnType, knownTypes));
         return method.WithReturnType(newReturnType).WithModifiers(newModifiers);
     }
 
     private static LocalFunctionStatementSyntax FixLocalFunction(
         bool keepVoid,
         IMethodSymbol methodSymbol,
         LocalFunctionStatementSyntax localFunction,
-        KnownTaskTypes knownTypes,
-        CancellationToken cancellationToken)
+        KnownTaskTypes knownTypes)
     {
         var (newModifiers, newReturnType) = AddAsyncModifierWithCorrectedTrivia(
             localFunction.Modifiers,
-            FixMethodReturnType(keepVoid, methodSymbol, localFunction.ReturnType, knownTypes, cancellationToken));
+            FixMethodReturnType(keepVoid, methodSymbol, localFunction.ReturnType, knownTypes));
         return localFunction.WithReturnType(newReturnType).WithModifiers(newModifiers);
     }
 
     private static TypeSyntax FixMethodReturnType(
         bool keepVoid,
         IMethodSymbol methodSymbol,
         TypeSyntax returnTypeSyntax,
-        KnownTaskTypes knownTypes,
-        CancellationToken cancellationToken)
+        KnownTaskTypes knownTypes)
     {
         var newReturnType = returnTypeSyntax.WithAdditionalAnnotations(Formatter.Annotation);
 
@@ -128,13 +124,13 @@ private static TypeSyntax FixMethodReturnType(
         else
         {
             var returnType = methodSymbol.ReturnType;
-            if (IsIEnumerable(returnType, knownTypes) && IsIterator(methodSymbol, cancellationToken))
+            if (IsIEnumerable(returnType, knownTypes) && methodSymbol.IsIterator)
             {
                 newReturnType = knownTypes.IAsyncEnumerableOfTType is null
                     ? MakeGenericType(nameof(IAsyncEnumerable<>), methodSymbol.ReturnType)
                     : knownTypes.IAsyncEnumerableOfTType.Construct(methodSymbol.ReturnType.GetTypeArguments()[0]).GenerateTypeSyntax();
             }
-            else if (IsIEnumerator(returnType, knownTypes) && IsIterator(methodSymbol, cancellationToken))
+            else if (IsIEnumerator(returnType, knownTypes) && methodSymbol.IsIterator)
             {
                 newReturnType = knownTypes.IAsyncEnumeratorOfTType is null
                     ? MakeGenericType(nameof(IAsyncEnumerator<>), methodSymbol.ReturnType)
@@ -164,9 +160,6 @@ static TypeSyntax MakeGenericType(string type, ITypeSymbol typeArgumentFrom)
         }
     }
 
-    private static bool IsIterator(IMethodSymbol method, CancellationToken cancellationToken)
-        => method.Locations.Any(static (loc, cancellationToken) => loc.FindNode(cancellationToken).ContainsYield(), cancellationToken);
-
     private static bool IsIAsyncEnumerableOrEnumerator(ITypeSymbol returnType, KnownTaskTypes knownTypes)
         => returnType.OriginalDefinition.Equals(knownTypes.IAsyncEnumerableOfTType) ||
            returnType.OriginalDefinition.Equals(knownTypes.IAsyncEnumeratorOfTType);

src/Analyzers/Core/CodeFixes/MakeMethodAsynchronous/AbstractMakeMethodAsynchronousCodeFixProvider.cs

@@ -25,7 +25,7 @@ internal abstract partial class AbstractMakeMethodAsynchronousCodeFixProvider :
     protected abstract bool IsAsyncReturnType(ITypeSymbol type, KnownTaskTypes knownTypes);
 
     protected abstract SyntaxNode AddAsyncTokenAndFixReturnType(
-        bool keepVoid, IMethodSymbol methodSymbol, SyntaxNode node, KnownTaskTypes knownTypes, CancellationToken cancellationToken);
+        bool keepVoid, IMethodSymbol methodSymbol, SyntaxNode node, KnownTaskTypes knownTypes);
 
     public override FixAllProvider GetFixAllProvider() => WellKnownFixAllProviders.BatchFixer;
 
@@ -188,7 +188,7 @@ private async Task<Solution> AddAsyncTokenAsync(
         SyntaxNode node,
         CancellationToken cancellationToken)
     {
-        var newNode = AddAsyncTokenAndFixReturnType(keepVoid, methodSymbol, node, knownTypes, cancellationToken);
+        var newNode = AddAsyncTokenAndFixReturnType(keepVoid, methodSymbol, node, knownTypes);
 
         var root = await document.GetRequiredSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
         var newRoot = root.ReplaceNode(node, newNode);

src/Analyzers/VisualBasic/CodeFixes/MakeMethodAsynchronous/VisualBasicMakeMethodAsynchronousCodeFixProvider.vb

@@ -61,8 +61,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.MakeMethodAsynchronous
                 keepVoid As Boolean,
                 methodSymbolOpt As IMethodSymbol,
                 node As SyntaxNode,
-                knownTypes As KnownTaskTypes,
-                cancellationToken As CancellationToken) As SyntaxNode
+                knownTypes As KnownTaskTypes) As SyntaxNode
 
             If node.IsKind(SyntaxKind.SingleLineSubLambdaExpression) OrElse
                node.IsKind(SyntaxKind.SingleLineFunctionLambdaExpression) Then