ContainerControl incorrectly scales multiple times when moving from one ControlCollection to another.

[ChristopherDShea]

.NET version

.NET 8.0

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

Sample project appears to work in .NET 6.

Issue description

Setup:
The parent form has AutoScaleMode set to DPI, and is being shown on a display with resolution that would cause the form to scale (i.e. not 100%).

Issue:
When a ContainerControl is removed from one Controls collection and added to another, the ContainerControl is scaled multiple times (based on the default and inherited fonts?), leading to the size of the control changing each time it is moved.

Notice in the animation below, the size of the TextBox remains static, while the red ContainerControl gets longer.

Steps to reproduce

ContainerControlSample.zip

1. Run the sample on a display set above 100%.
2. Click button3 on the initial Form2 to pull up the Form4 with the issue.
3. Repeatedly click button1 on Form4.

Results:
The red ContainerControl gets longer with each button1 click.

[Tanya-Solyanik]

Please find the commit that introduced this issue and see if this is controlled by any quirks.

[LeafShi1]

@ChristopherDShea This doesn't seem to be a real problem. It caused by using AutoScaleDimensions = new SizeF(96F, 96F); on non-100% screen
If AutoScaleDimensions uses the automatically generated size( on 150% DPI, the value should be 144X144), there will be no problem.

[ChristopherDShea]

This is a problem.

The AutoScaleDimensions property on the form is automatically generated by the designer when the form is serialized out. It is used to keep track of the resolution the form was designed in so it can scale values based on the difference between the resolution when serialized out versus when the form is being run at runtime. The AutoScaleDimensions is not defining the resolution the form can be run at, but what is was design at.

It should be fairly commonplace for application to be designed in one resolution while it is run in another as the developer and the end user are often different.