Skip to content

Commit 69c3a65

Browse files
committed
Set classified-sort option to false by default as it caused confusion
The classified-sort option was previously set to true by default, which led to confusion for many users. It wasn't an intentional decision, so we're updating the default to false to avoid unexpected column ordering.
1 parent 4611f33 commit 69c3a65

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/annotate_rb/parser.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ def add_options_to_parser(option_parser) # rubocop:disable Metrics/MethodLength
394394

395395
option_parser.on("--classified-sort",
396396
"Sort columns alphabetically, but first goes id, then the rest columns, then the timestamp columns and then the association columns") do
397-
@options[:classified_sort] = true
397+
@options[:classified_sort] = false
398398
end
399399

400400
option_parser.on("-R",

spec/lib/annotate_rb/parser_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ module AnnotateRb # rubocop:disable Metrics/ModuleLength
355355
let(:args) { ["--classified-sort"] }
356356

357357
it "sets classified_sort to true" do
358-
expect(result).to include(classified_sort: true)
358+
expect(result).to include(classified_sort: false)
359359
end
360360
end
361361

0 commit comments

Comments
 (0)