Skip to content

Commit a9bf07c

Browse files
committed
Address feedback from Quentin
Signed-off-by: Dave Thaler <[email protected]>
1 parent ae1018c commit a9bf07c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

isa/kernel.org/instruction-set.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -508,15 +508,15 @@ BPF_IMM | BPF_DW | BPF_LD 0x18 0x1 dst = map_by_fd(imm) m
508508
BPF_IMM | BPF_DW | BPF_LD 0x18 0x2 dst = mva(map_by_fd(imm)) + next_imm map fd data pointer
509509
BPF_IMM | BPF_DW | BPF_LD 0x18 0x3 dst = variable_addr(imm) variable id data pointer
510510
BPF_IMM | BPF_DW | BPF_LD 0x18 0x4 dst = code_addr(imm) integer code pointer
511-
BPF_IMM | BPF_DW | BPF_LD 0x18 0x5 dst = mva(map_by_idx(imm)) map index map
511+
BPF_IMM | BPF_DW | BPF_LD 0x18 0x5 dst = map_by_idx(imm) map index map
512512
BPF_IMM | BPF_DW | BPF_LD 0x18 0x6 dst = mva(map_by_idx(imm)) + next_imm map index data pointer
513513
========================= ====== === ===================================== =========== ==============
514514

515515
where
516516

517517
* map_by_fd(fd) means to convert a 32-bit POSIX file descriptor into an address of a map object (see `Map objects`_)
518518
* map_by_index(index) means to convert a 32-bit index into an address of a map object
519-
* mva(map) gets the address of the memory region expressed by a given map object
519+
* mva(map) gets the address of the first value in a given map object
520520
* variable_addr(id) gets the address of a variable (see `Variables`_) with a given id
521521
* code_addr(offset) gets the address of the instruction at a specified relative offset in units of 64-bit blocks
522522
* the 'imm type' can be used by disassemblers for display
@@ -586,7 +586,7 @@ opcode src imm description referenc
586586
0x18 0x2 0x00 dst = mva(map_by_fd(imm)) + next_imm `64-bit immediate instructions`_
587587
0x18 0x3 0x00 dst = variable_addr(imm) `64-bit immediate instructions`_
588588
0x18 0x4 0x00 dst = code_addr(imm) `64-bit immediate instructions`_
589-
0x18 0x5 0x00 dst = mva(map_by_idx(imm)) `64-bit immediate instructions`_
589+
0x18 0x5 0x00 dst = map_by_idx(imm) `64-bit immediate instructions`_
590590
0x18 0x6 0x00 dst = mva(map_by_idx(imm)) + next_imm `64-bit immediate instructions`_
591591
0x1c any 0x00 dst = (uint32_t)(dst - src) `Arithmetic instructions`_
592592
0x1d any 0x00 if dst == src goto +offset `Jump instructions`_

0 commit comments

Comments
 (0)