rename to BrowserAndInputScreenTransitionProviderImpl and use DI

Author: LukasPaczos

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -287,7 +287,7 @@ import com.duckduckgo.downloads.api.DownloadsFileActions
 import com.duckduckgo.downloads.api.FileDownloader
 import com.duckduckgo.downloads.api.FileDownloader.PendingFileDownload
 import com.duckduckgo.duckchat.api.DuckChat
-import com.duckduckgo.duckchat.api.InputScreenAnimationResourceProvider
+import com.duckduckgo.duckchat.api.inputscreen.BrowserAndInputScreenTransitionProvider
 import com.duckduckgo.duckchat.impl.inputscreen.ui.InputScreenActivity.Companion.QUERY
 import com.duckduckgo.duckchat.impl.inputscreen.ui.InputScreenActivity.Companion.TAB_ID
 import com.duckduckgo.duckchat.impl.inputscreen.ui.InputScreenActivityParams
@@ -574,6 +574,9 @@ class BrowserTabFragment :
     @Inject
     lateinit var omnibarTypeResolver: OmnibarTypeResolver
 
+    @Inject
+    lateinit var browserAndInputScreenTransitionProvider: BrowserAndInputScreenTransitionProvider
+
     /**
      * We use this to monitor whether the user was seeing the in-context Email Protection signup prompt
      * This is needed because the activity stack will be cleared if an external link is opened in our browser
@@ -1075,8 +1078,8 @@ class BrowserTabFragment :
                 requireContext(),
                 InputScreenActivityParams(query = query),
             )
-            val enterTransition = InputScreenAnimationResourceProvider.getInputScreenEnterAnimation()
-            val exitTransition = InputScreenAnimationResourceProvider.getBrowserExitAnimation(appTheme.isLightModeEnabled())
+            val enterTransition = browserAndInputScreenTransitionProvider.getInputScreenEnterAnimation()
+            val exitTransition = browserAndInputScreenTransitionProvider.getBrowserExitAnimation()
             val options = ActivityOptionsCompat.makeCustomAnimation(
                 requireActivity(),
                 enterTransition,

duckchat/duckchat-api/src/main/java/com/duckduckgo/duckchat/api/inputscreen/BrowserAndInputScreenTransitionProvider.kt

@@ -0,0 +1,31 @@
+/*
+ * Copyright (c) 2025 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.duckchat.api.inputscreen
+
+/**
+ * Provides animation resources for activity transitions between browser and input screen.
+ */
+interface BrowserAndInputScreenTransitionProvider {
+
+    fun getBrowserEnterAnimation(): Int
+
+    fun getBrowserExitAnimation(): Int
+
+    fun getInputScreenEnterAnimation(): Int
+
+    fun getInputScreenExitAnimation(): Int
+}

duckchat/duckchat-api/src/main/java/com/duckduckgo/duckchat/api/InputScreenAnimationResourceProvider.kt renamed to duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/BrowserAndInputScreenTransitionProviderImpl.kt

@@ -14,12 +14,18 @@
  * limitations under the License.
  */
 
-package com.duckduckgo.duckchat.api
+package com.duckduckgo.duckchat.impl.inputscreen.ui
 
 import android.os.Build.VERSION
+import com.duckduckgo.common.ui.store.AppTheme
+import com.duckduckgo.di.scopes.AppScope
+import com.duckduckgo.duckchat.api.R
+import com.duckduckgo.duckchat.api.inputscreen.BrowserAndInputScreenTransitionProvider
+import com.squareup.anvil.annotations.ContributesBinding
+import javax.inject.Inject
 
 /**
- * Provides animation resources for activity transitions between input screens and browser.
+ * Provides animation resources for activity transitions between browser and input screen.
  *
  * ### API Level Behavior
  * - **API < 33**: Uses simple fade animations as slide animations don't seem to be supported (on tested devices).
@@ -38,11 +44,14 @@ import android.os.Build.VERSION
  * - Cannot use themeable attributes (`?attr`) as they cause crashes of the whole launcher (on tested devices).
  *   Instead, we use fixed color values and filter resources by current theme state.
  */
-object InputScreenAnimationResourceProvider {
+@ContributesBinding(scope = AppScope::class)
+class BrowserAndInputScreenTransitionProviderImpl @Inject constructor(
+    private val appTheme: AppTheme,
+) : BrowserAndInputScreenTransitionProvider {
 
-    fun getBrowserEnterAnimation(isLightModeEnabled: Boolean): Int {
+    override fun getBrowserEnterAnimation(): Int {
         return if (VERSION.SDK_INT >= 33) {
-            if (isLightModeEnabled) {
+            if (appTheme.isLightModeEnabled()) {
                 R.anim.slide_in_from_bottom_fade_in_light
             } else {
                 R.anim.slide_in_from_bottom_fade_in_dark
@@ -52,29 +61,29 @@ object InputScreenAnimationResourceProvider {
         }
     }
 
-    fun getInputScreenExitAnimation(): Int {
+    override fun getBrowserExitAnimation(): Int {
         return if (VERSION.SDK_INT >= 33) {
-            R.anim.slide_out_to_top_fade_out
+            if (appTheme.isLightModeEnabled()) {
+                R.anim.slide_out_to_bottom_fade_out_light
+            } else {
+                R.anim.slide_out_to_bottom_fade_out_dark
+            }
         } else {
             R.anim.fade_out
         }
     }
 
-    fun getInputScreenEnterAnimation(): Int {
+    override fun getInputScreenEnterAnimation(): Int {
         return if (VERSION.SDK_INT >= 33) {
             R.anim.slide_in_from_top_fade_in
         } else {
             R.anim.fade_in
         }
     }
 
-    fun getBrowserExitAnimation(isLightModeEnabled: Boolean): Int {
+    override fun getInputScreenExitAnimation(): Int {
         return if (VERSION.SDK_INT >= 33) {
-            if (isLightModeEnabled) {
-                R.anim.slide_out_to_bottom_fade_out_light
-            } else {
-                R.anim.slide_out_to_bottom_fade_out_dark
-            }
+            R.anim.slide_out_to_top_fade_out
         } else {
             R.anim.fade_out
         }

duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/InputScreenActivity.kt

@@ -21,9 +21,8 @@ import android.os.Bundle
 import com.duckduckgo.anvil.annotations.ContributeToActivityStarter
 import com.duckduckgo.anvil.annotations.InjectWith
 import com.duckduckgo.common.ui.DuckDuckGoActivity
-import com.duckduckgo.common.ui.store.BrowserAppTheme
 import com.duckduckgo.di.scopes.ActivityScope
-import com.duckduckgo.duckchat.api.InputScreenAnimationResourceProvider
+import com.duckduckgo.duckchat.api.inputscreen.BrowserAndInputScreenTransitionProvider
 import com.duckduckgo.duckchat.impl.R
 import com.duckduckgo.navigation.api.GlobalActivityStarter
 import javax.inject.Inject
@@ -37,7 +36,7 @@ data class InputScreenActivityParams(
 class InputScreenActivity : DuckDuckGoActivity() {
 
     @Inject
-    lateinit var appTheme: BrowserAppTheme
+    lateinit var browserAndInputScreenTransitionProvider: BrowserAndInputScreenTransitionProvider
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
@@ -50,8 +49,8 @@ class InputScreenActivity : DuckDuckGoActivity() {
     }
 
     private fun applyExitTransition() {
-        val enterTransition = InputScreenAnimationResourceProvider.getBrowserEnterAnimation(appTheme.isLightModeEnabled())
-        val exitTransition = InputScreenAnimationResourceProvider.getInputScreenExitAnimation()
+        val enterTransition = browserAndInputScreenTransitionProvider.getBrowserEnterAnimation()
+        val exitTransition = browserAndInputScreenTransitionProvider.getInputScreenExitAnimation()
 
         if (VERSION.SDK_INT >= 34) {
             overrideActivityTransition(