Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Nov 21, 2025

Asana Task/Github Issue:

Description

Allow for remote config for the timing data for LCP.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Adds a configurable timeout for collecting LCP in expanded performance metrics, sourced from feature setting and propagated to metric collection.

  • Expanded performance metrics:
    • getExpandedPerformanceMetrics(timeoutMs) now accepts a timeout (default 500 ms) and forwards it to waitForLCP.
  • Feature wiring:
    • PerformanceMetrics.triggerExpandedPerformanceMetrics reads expandedTimeoutMs (default 5000 ms) from feature settings and passes it to getExpandedPerformanceMetrics.

Written by Cursor Bugbot for commit 2c2ac98. This will update automatically on new commits. Configure here.

Added timeout parameter to getExpandedPerformanceMetrics function to control waiting time for largest contentful paint.
@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 2c2ac98
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6929dc7cc8abf0000874ea7e
😎 Deploy Preview https://deploy-preview-2057--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

[Beta] Generated file diff

Time updated: Fri, 28 Nov 2025 17:32:46 GMT

Android
    - android/adsjsContentScope.js
  • android/contentScope.js

File has changed

Apple
    - apple/contentScopeIsolated.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review November 22, 2025 15:21
@jonathanKingston jonathanKingston requested a review from a team as a code owner November 22, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants