Commit 68b9017
Fix: compute device partial load (invoke-ai#9375)
* fix(vae): decode on the model's intended compute device, not current residency (invoke-ai#9373)
VAE decode inferred its device via get_effective_device(vae). Under partial
loading with VRAM pressure, all VAE weights can be temporarily offloaded to
RAM, so that returned CPU — placing the latents on CPU and, because the
autocast layers follow the input device, running the entire decode on CPU.
Expose LoadedModel.compute_device (the model's intended device, stable across
partial-load residency and still honoring cpu_only) and use it in all 8 decode
invocations. Adds a regression test reproducing the offloaded-weights case.
* fix(text-encoder): encode on the intended compute device, not current residency
Same class of bug as invoke-ai#9373, for text encoders: get_effective_device() returns
CPU when partial loading has offloaded all weights, running the whole encode on
CPU. Fully autocast-capable encoders (e.g. CLIP) are affected because
repair_required_tensors_on_device() pins nothing to the compute device.
Use LoadedModel.compute_device in compel, sd3, z_image, flux2_klein, cogview4
and qwen_image encoders, and thread it through HFEncoder for the FLUX encoder.
Updates the affected tests to assert the intended-device behavior.
* fix(tests): set vae_info.compute_device in qwen/z-image decode mocks
Like the anima decode test, the qwen-image and z-image working-memory
tests build vae_info as a bare MagicMock and drive invoke(). Since invoke-ai#9373
places latents on vae_info.compute_device, latents.to(device=...) raised
TypeError — but both tests wrapped invoke() in `except Exception: pass`,
so the failure was silently swallowed and the decode path never actually
ran. Set compute_device to torch.device("cpu") so the tests exercise the
real decode path instead of masking the error.
* fix(text-encoder): anima encodes on the intended compute device, not current residency
The anima text encoder inferred its device via text_encoder.device (HF
PreTrainedModel residency), which returns CPU when partial loading has
temporarily offloaded all Qwen3 weights to RAM — running the whole encode on
the CPU. This is the same class of bug as invoke-ai#9373; the other text encoders and
VAE decodes in this PR were already fixed, but the anima encoder was missed.
Use LoadedModel.compute_device instead. This also corrects the device passed to
TorchDevice.choose_anima_inference_dtype(). Adds a regression test covering both
the offloaded-accelerator case and the cpu_only case.
---------
Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com>1 parent 350eda6 commit 68b9017
27 files changed
Lines changed: 403 additions & 67 deletions
File tree
- invokeai
- app/invocations
- backend
- flux/modules
- model_manager/load
- tests
- app/invocations
- backend
- flux/modules
- model_manager/load
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
| |||
127 | 126 | | |
128 | 127 | | |
129 | 128 | | |
130 | | - | |
131 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
129 | 132 | | |
130 | 133 | | |
131 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
58 | | - | |
59 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
52 | 51 | | |
53 | 52 | | |
54 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
55 | 57 | | |
56 | | - | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| |||
104 | 103 | | |
105 | 104 | | |
106 | 105 | | |
107 | | - | |
| 106 | + | |
108 | 107 | | |
109 | 108 | | |
110 | 109 | | |
| |||
213 | 212 | | |
214 | 213 | | |
215 | 214 | | |
216 | | - | |
| 215 | + | |
217 | 216 | | |
218 | 217 | | |
219 | 218 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
| |||
101 | 100 | | |
102 | 101 | | |
103 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
104 | 106 | | |
105 | | - | |
| 107 | + | |
106 | 108 | | |
107 | 109 | | |
108 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
| |||
52 | 51 | | |
53 | 52 | | |
54 | 53 | | |
55 | | - | |
56 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
119 | 121 | | |
120 | 122 | | |
121 | 123 | | |
| |||
158 | 160 | | |
159 | 161 | | |
160 | 162 | | |
161 | | - | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
162 | 166 | | |
163 | 167 | | |
164 | 168 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
| |||
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
51 | | - | |
52 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
70 | 69 | | |
71 | 70 | | |
72 | 71 | | |
73 | | - | |
74 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
| |||
0 commit comments