From 8a6206bbfe08f872b662b9f57ed4080fe99f59f8 Mon Sep 17 00:00:00 2001 From: Tom Robinson Date: Fri, 19 Jan 2024 00:20:36 -0800 Subject: [PATCH 1/3] Add commented out lines that appear in video at https://youtu.be/MJAvyt9v0g4?t=246, which seem important to the lesson. --- CH01/CH01_SEC03_Rotation.ipynb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CH01/CH01_SEC03_Rotation.ipynb b/CH01/CH01_SEC03_Rotation.ipynb index 110deca..f818c60 100644 --- a/CH01/CH01_SEC03_Rotation.ipynb +++ b/CH01/CH01_SEC03_Rotation.ipynb @@ -31,7 +31,9 @@ " [0, 0, 1]])\n", "\n", "# Rotate and scale\n", - "X = Rz @ Ry @ Rx @ Sigma" + "X = Rz @ Ry @ Rx @ Sigma", + "# U, S, Vt = np.linalg.svd(X, full_matrices=False)", + "# X = U @ np.diag(S)" ] }, { From 4862cf459e872fa0c9fb70ba10ea062344da9600 Mon Sep 17 00:00:00 2001 From: Tom Robinson Date: Fri, 19 Jan 2024 00:20:36 -0800 Subject: [PATCH 2/3] Add commented out lines that appear in video at https://youtu.be/MJAvyt9v0g4?t=246, which seem important to the lesson. --- CH01/CH01_SEC03_Rotation.ipynb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CH01/CH01_SEC03_Rotation.ipynb b/CH01/CH01_SEC03_Rotation.ipynb index 110deca..f818c60 100644 --- a/CH01/CH01_SEC03_Rotation.ipynb +++ b/CH01/CH01_SEC03_Rotation.ipynb @@ -31,7 +31,9 @@ " [0, 0, 1]])\n", "\n", "# Rotate and scale\n", - "X = Rz @ Ry @ Rx @ Sigma" + "X = Rz @ Ry @ Rx @ Sigma", + "# U, S, Vt = np.linalg.svd(X, full_matrices=False)", + "# X = U @ np.diag(S)" ] }, { From 2bdec4090cd3652b2b6d7606161e63e7d3637c9e Mon Sep 17 00:00:00 2001 From: Tom Robinson Date: Fri, 19 Jan 2024 00:35:33 -0800 Subject: [PATCH 3/3] Add missing LFs --- CH01/CH01_SEC03_Rotation.ipynb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CH01/CH01_SEC03_Rotation.ipynb b/CH01/CH01_SEC03_Rotation.ipynb index f818c60..43229d3 100644 --- a/CH01/CH01_SEC03_Rotation.ipynb +++ b/CH01/CH01_SEC03_Rotation.ipynb @@ -31,8 +31,8 @@ " [0, 0, 1]])\n", "\n", "# Rotate and scale\n", - "X = Rz @ Ry @ Rx @ Sigma", - "# U, S, Vt = np.linalg.svd(X, full_matrices=False)", + "X = Rz @ Ry @ Rx @ Sigma\n", + "# U, S, Vt = np.linalg.svd(X, full_matrices=False)\n", "# X = U @ np.diag(S)" ] },