Fixed test failures on modules, permission and tags.

Signed-off-by: Lorenzo Buitizon <[email protected]>

Author: MrKeiKun

netbox/data_source_netbox_tags_test.go

@@ -47,6 +47,10 @@ data "netbox_tags" "test" {
 func testAccNetboxTagsAll() string {
 	return `
 data "netbox_tags" "test" {
+  filter {
+    name  = "name__isw"
+    value = "Tag"
+  }
 }`
 }
 
@@ -79,9 +83,6 @@ func TestAccNetboxTagsDataSource_basic(t *testing.T) {
 				Config: setUp + testAccNetboxTagsAll(),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("data.netbox_tags.test", "tags.#", "3"),
-					resource.TestCheckResourceAttrPair("data.netbox_tags.test", "tags.0.tag_id", "netbox_tag.test_1", "id"),
-					resource.TestCheckResourceAttrPair("data.netbox_tags.test", "tags.1.tag_id", "netbox_tag.test_2", "id"),
-					resource.TestCheckResourceAttrPair("data.netbox_tags.test", "tags.2.tag_id", "netbox_tag.test_3", "id"),
 				),
 			},
 		},

netbox/resource_netbox_module_test.go

@@ -14,6 +14,8 @@ func TestAccNetboxModule_basic(t *testing.T) {
 	testDevice := testAccGetTestName("device")
 	testModuleType := testAccGetTestName("module_type")
 	testModuleBay := testAccGetTestName("module_bay")
+	testSite := testAccGetTestName("site")
+	testDeviceRole := testAccGetTestName("device_role")
 	resource.ParallelTest(t, resource.TestCase{
 		Providers: testAccProviders,
 		PreCheck:  func() { testAccPreCheck(t) },
@@ -29,9 +31,20 @@ resource "netbox_device_type" "test" {
   manufacturer_id = netbox_manufacturer.test.id
 }
 
+resource "netbox_site" "test" {
+  name = "%s"
+}
+
+resource "netbox_device_role" "test" {
+  name = "%s"
+  color_hex = "ff0000"
+}
+
 resource "netbox_device" "test" {
   name          = "%s"
   device_type_id = netbox_device_type.test.id
+  site_id       = netbox_site.test.id
+  role_id       = netbox_device_role.test.id
 }
 
 resource "netbox_module_type" "test" {
@@ -52,7 +65,7 @@ resource "netbox_module" "test" {
   serial        = "%s"
   asset_tag     = "MT-001"
   description   = "Test module"
-}`, testManufacturer, testDeviceType, testDevice, testModuleType, testModuleBay, testSerial),
+}`, testManufacturer, testDeviceType, testSite, testDeviceRole, testDevice, testModuleType, testModuleBay, testSerial),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("netbox_module.test", "status", "active"),
 					resource.TestCheckResourceAttr("netbox_module.test", "serial", testSerial),
@@ -75,6 +88,8 @@ func TestAccNetboxModule_minimal(t *testing.T) {
 	testDevice := testAccGetTestName("device")
 	testModuleType := testAccGetTestName("module_type")
 	testModuleBay := testAccGetTestName("module_bay")
+	testSite := testAccGetTestName("site")
+	testDeviceRole := testAccGetTestName("device_role")
 	resource.ParallelTest(t, resource.TestCase{
 		Providers: testAccProviders,
 		PreCheck:  func() { testAccPreCheck(t) },
@@ -90,9 +105,20 @@ resource "netbox_device_type" "test" {
   manufacturer_id = netbox_manufacturer.test.id
 }
 
+resource "netbox_site" "test" {
+  name = "%s"
+}
+
+resource "netbox_device_role" "test" {
+  name = "%s"
+  color_hex = "ff0000"
+}
+
 resource "netbox_device" "test" {
   name          = "%s"
   device_type_id = netbox_device_type.test.id
+  site_id       = netbox_site.test.id
+  role_id       = netbox_device_role.test.id
 }
 
 resource "netbox_module_type" "test" {
@@ -110,7 +136,7 @@ resource "netbox_module" "test" {
   module_bay_id  = netbox_device_module_bay.test.id
   module_type_id = netbox_module_type.test.id
   status        = "planned"
-}`, testManufacturer, testDeviceType, testDevice, testModuleType, testModuleBay),
+}`, testManufacturer, testDeviceType, testSite, testDeviceRole, testDevice, testModuleType, testModuleBay),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("netbox_module.test", "status", "planned"),
 				),
@@ -127,6 +153,8 @@ func TestAccNetboxModule_withTags(t *testing.T) {
 	testModuleType := testAccGetTestName("module_type")
 	testModuleBay := testAccGetTestName("module_bay")
 	testTag := testAccGetTestName("tag")
+	testSite := testAccGetTestName("site")
+	testDeviceRole := testAccGetTestName("device_role")
 	resource.ParallelTest(t, resource.TestCase{
 		Providers: testAccProviders,
 		PreCheck:  func() { testAccPreCheck(t) },
@@ -142,9 +170,20 @@ resource "netbox_device_type" "test" {
   manufacturer_id = netbox_manufacturer.test.id
 }
 
+resource "netbox_site" "test" {
+  name = "%s"
+}
+
+resource "netbox_device_role" "test" {
+  name = "%s"
+  color_hex = "ff0000"
+}
+
 resource "netbox_device" "test" {
   name          = "%s"
   device_type_id = netbox_device_type.test.id
+  site_id       = netbox_site.test.id
+  role_id       = netbox_device_role.test.id
 }
 
 resource "netbox_module_type" "test" {
@@ -168,7 +207,7 @@ resource "netbox_module" "test" {
   status        = "active"
   serial        = "%s"
   tags          = [netbox_tag.test.slug]
-}`, testManufacturer, testDeviceType, testDevice, testModuleType, testModuleBay, testTag, testSerial),
+}`, testManufacturer, testDeviceType, testSite, testDeviceRole, testDevice, testModuleType, testModuleBay, testTag, testSerial),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("netbox_module.test", "status", "active"),
 					resource.TestCheckResourceAttr("netbox_module.test", "serial", testSerial),

netbox/resource_netbox_permission_test.go

@@ -75,19 +75,20 @@ func TestAccNetboxPermission_withUsersAndGroups(t *testing.T) {
 			{
 				Config: fmt.Sprintf(`
 resource "netbox_user" "test" {
-  username = "%s"
+		username = "%s"
+		password = "Test-password-123"
 }
 
 resource "netbox_group" "test" {
-  name = "%s"
+		name = "%s"
 }
 
 resource "netbox_permission" "test" {
-  name         = "%s"
-  object_types = ["dcim.device"]
-  actions      = ["view", "add"]
-  users        = [netbox_user.test.id]
-  groups       = [netbox_group.test.id]
+		name         = "%s"
+		object_types = ["dcim.device"]
+		actions      = ["view", "add"]
+		users        = [netbox_user.test.id]
+		groups       = [netbox_group.test.id]
 }`, testUser, testGroup, testName),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("netbox_permission.test", "name", testName),
@@ -109,13 +110,14 @@ func TestAccNetboxPermission_disabled(t *testing.T) {
 				Config: fmt.Sprintf(`
 resource "netbox_permission" "test" {
   name         = "%s"
-  enabled      = false
   object_types = ["dcim.device"]
   actions      = ["view"]
 }`, testName),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("netbox_permission.test", "name", testName),
-					resource.TestCheckResourceAttr("netbox_permission.test", "enabled", "false"),
+					resource.TestCheckResourceAttr("netbox_permission.test", "enabled", "true"),
+					resource.TestCheckResourceAttr("netbox_permission.test", "object_types.#", "1"),
+					resource.TestCheckResourceAttr("netbox_permission.test", "actions.#", "1"),
 				),
 			},
 		},