`e18e/prefer-static-regex`: Inacurate error message

[gkubisa]

e18e/prefer-static-regex shows the error "Move this regular expression to module scope to avoid re-compilation on every call." but that message is inaccurate because literal regexes are compiled once and cached, and the per-use cost is just a thin object wrapper (pointer to the compiled regex and lastIndex). It's the same as with nested functions - compiled once, thin wrapper on use. So, the rule is actually more about a preference to define all literal regexes at the module level because the performance improvement is negligible. Could we adjust the error message accordingly, please?

Reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_expressions#creating_a_regular_expression

Regular expression literals provide compilation of the regular expression when the script is loaded. If the regular expression remains constant, using this can improve performance.

[43081j]

this is true but the rule also covers new RegExp of static values, which is what the message was leaning more towards.

do you know if engines do the same for those usages? Probably not I'd guess.

so we probably need to word it more to distinguish the two rather than changing it entirely. open to suggestions