Remove deprecated ConcurrentMessageProcessor.startProcessing

use ConcurrentMessageProcessor.beginProcessing instead

Fixes #922

Author: jonahgraham

CHANGELOG.md

@@ -16,6 +16,7 @@ Breaking API changes:
     * Remove deprecated factories [#878](https://github.com/eclipse-lsp4j/lsp4j/issues/878)
     * Remove deprecated ResponseErrorCode.serverNotInitialized, use ResponseErrorCode.ServerNotInitialized instead [#879](https://github.com/eclipse-lsp4j/lsp4j/issues/879)
     * Remove deprecated org.eclipse.lsp4j.websocket. Please upgrade to using Jakarta or remain with LSP4J version 0.x.x [#647](https://github.com/eclipse-lsp4j/lsp4j/issues/647)
+    * Remove deprecated ConcurrentMessageProcessor.startProcessing, use ConcurrentMessageProcessor.beginProcessing instead [#922](https://github.com/eclipse-lsp4j/lsp4j/issues/922)
 
 japicmp report: <https://download.eclipse.org/lsp4j/builds/main/japicmp-report/>
 

org.eclipse.lsp4j.jsonrpc/src/main/java/org/eclipse/lsp4j/jsonrpc/json/ConcurrentMessageProcessor.java

@@ -29,23 +29,6 @@
  */
 public class ConcurrentMessageProcessor implements Runnable {
 
-	/**
-	 * Start a thread that listens for messages in the message producer and forwards them to the message consumer.
-	 *
-	 * @param messageProducer - produces messages, e.g. by reading from an input channel
-	 * @param messageConsumer - processes messages and potentially forwards them to other consumers
-	 * @param executorService - the thread is started using this service
-	 * @return a future that is resolved when the started thread is terminated, e.g. by closing a stream
-	 * @deprecated Please use the non-static {@link #beginProcessing} instead.
-	 */
-	@Deprecated
-	public static Future<Void> startProcessing(MessageProducer messageProducer, MessageConsumer messageConsumer,
-			ExecutorService executorService) {
-		final var reader = new ConcurrentMessageProcessor(messageProducer, messageConsumer);
-		final Future<?> result = executorService.submit(reader);
-		return wrapFuture(result, messageProducer);
-	}
-
 	public static Future<Void> wrapFuture(Future<?> result, MessageProducer messageProducer) {
 		return new Future<>() {