Issue 40 + refactoring for better layout and more efficient restart process

Author: Dale McDiarmid

handlers/main.yml

@@ -1,4 +1,4 @@
 
 - name: restart elasticsearch
   service: name={{instance_init_script | basename}} state=restarted enabled=yes
-  when: es_start_service and (not elasticsearch_started.changed or (plugin_installed is defined and plugin_installed.changed))
+  when: es_start_service and (not elasticsearch_started.changed or (plugin_installed is defined and plugin_installed.changed) or elasticsearch_install.changed)

tasks/elasticsearch-config.yml

@@ -10,10 +10,7 @@
 #Relies on elasticsearch distribution installing a serviced script to determine whether one should be copied.
 
 
-- stat: path={{sysd_script}}
-  register: systemd_service
-
-- set_fact: use_system_d={{systemd_service.stat.exists and ((ansible_distribution == 'Debian' and ansible_distribution_version | version_compare('8', '>=')) or (ansible_distribution == 'CentOS' and ansible_distribution_version | version_compare('7', '>=')) or (ansible_distribution == 'Ubuntu' and ansible_distribution_version | version_compare('15', '>='))) }}
+- set_fact: use_system_d={{(ansible_distribution == 'Debian' and ansible_distribution_version | version_compare('8', '>=')) or (ansible_distribution == 'CentOS' and ansible_distribution_version | version_compare('7', '>=')) or (ansible_distribution == 'Ubuntu' and ansible_distribution_version | version_compare('15', '>=')) }}
 
 - set_fact: instance_sysd_script={{sysd_script | dirname }}/{{es_instance_name}}_{{sysd_script | basename}}
   when: use_system_d
@@ -81,3 +78,17 @@
   notify: restart elasticsearch
 
 #Clean up un-wanted package scripts to avoid confusion
+
+- name: Delete Default Init
+  file: dest=/etc/init.d/elasticsearch state=absent
+
+- name: Delete Default Environment File
+  file: dest=/etc/default/elasticsearch state=absent
+  when: ansible_os_family == 'Debian'
+
+- name: Delete Default Environment File
+  file: dest=/etc/sysconfig/elasticsearch state=absent
+  when: ansible_os_family == 'RedHat'
+
+- name: Delete Default Sysconfig File
+  file: dest=/usr/lib/systemd/system/elasticsearch.service state=absent

tasks/elasticsearch-service.yml

@@ -0,0 +1,6 @@
+# Make sure the service is started, and restart if necessary
+- name: Start elasticsearch service
+  service: name={{instance_init_script | basename}} state=started enabled=yes
+  when: es_start_service
+  register: elasticsearch_started
+

tasks/elasticsearch.yml

@@ -16,17 +16,3 @@
 - name: Include specific Elasticsearch
   include: elasticsearch-RedHat.yml
   when: ansible_os_family == 'RedHat'
-
-#Configuration file for elasticsearch
-- name: Elasticsearch configuration
-  include: elasticsearch-config.yml
-
-# Make sure the service is started, and restart if necessary
-- name: Start elasticsearch service
-  service: name={{instance_init_script | basename}} state=started enabled=yes
-  when: es_start_service
-  register: elasticsearch_started
-
-- name: Restart elasticsearch service if new version installed
-  service: name={{instance_init_script | basename}} state=restarted enabled=yes
-  when: es_start_service and elasticsearch_install.changed and not elasticsearch_started.changed

tasks/main.yml

@@ -5,10 +5,12 @@
   include_vars: "{{ansible_os_family}}.yml"
 - include: java.yml
 - include: elasticsearch.yml
-- include: elasticsearch-plugins.yml
-  when: es_plugins is defined
+- include: elasticsearch-config.yml
 - include: elasticsearch-scripts.yml
   when: es_scripts
+- include: elasticsearch-plugins.yml
+  when: es_plugins is defined
+- include: elasticsearch-service.yml
 - include: elasticsearch-templates.yml
   when: es_templates
 - meta: flush_handlers

test/integration/helpers/serverspec/standard_spec.rb

@@ -47,5 +47,21 @@
     end
   end
 
+  describe file('/etc/init.d/elasticsearch') do
+    it { should_not exist }
+  end
+
+  describe file('/etc/default/elasticsearch') do
+    it { should_not exist }
+  end
+
+  describe file('/etc/sysconfig/elasticsearch') do
+    it { should_not exist }
+  end
+
+  describe file('/usr/lib/systemd/system/elasticsearch.service') do
+    it { should_not exist }
+  end
+
 end
 

vars/Debian.yml

@@ -1,5 +1,4 @@
 ---
 java: "openjdk-7-jre-headless"
 default_file: "/etc/default/elasticsearch"
-init_script: "/etc/init.d/elasticsearch"
 es_home: "/usr/share/elasticsearch"

vars/RedHat.yml

@@ -1,5 +1,4 @@
 ---
 java: "java-1.8.0-openjdk.x86_64"
 default_file: "/etc/sysconfig/elasticsearch"
-init_script: "/etc/init.d/elasticsearch"
 es_home: "/usr/share/elasticsearch"

vars/main.yml

@@ -1,4 +1,5 @@
 ---
 es_package_url: "https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch"
 es_conf_dir: "/etc/elasticsearch"
-sysd_script: "/usr/lib/systemd/system/elasticsearch.service"
+sysd_script: "/usr/lib/systemd/system/elasticsearch.service"
+init_script: "/etc/init.d/elasticsearch"