Add info comment to preview build - #1667
Merged
Merged
Conversation
Mpdreamz
requested changes
Aug 1, 2025
Mpdreamz
left a comment
Mpdreamz
left a comment
Member
There was a problem hiding this comment.
It'd be nice if we can rename disable-comments to disable-changes-comment, might be hard unless we support both for a while.
Mpdreamz
approved these changes
Aug 8, 2025
Mpdreamz
requested changes
Aug 12, 2025
leemthompo
reviewed
Aug 22, 2025
Mpdreamz
approved these changes
Aug 26, 2025
leemthompo
added a commit
to elastic/elasticsearch
that referenced
this pull request
Aug 26, 2025
shainaraskas
pushed a commit
to elastic/elasticsearch
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
As an attempt to centralize elastic/elasticsearch#132257
Changes
Add a step to the preview build that comments about versioning.
Usage
name: docs-build on: push: branches: - main pull_request_target: ~ merge_group: ~ jobs: docs-preview: uses: elastic/docs-builder/.github/workflows/preview-build.yml@main with: path-pattern: docs/** path-pattern-ignore: docs/changelog/**/*.yaml + enable-cumulative-comment: true permissions: deployments: write id-token: write contents: read pull-requests: write