Skip to content

Commit da79b17

Browse files
authored
Test Rails 6 (#902)
* [MODEL] Test Rails 6 * [MODEL] Catch mongoid load errors due to gem version conflicts * Also remoe Gemfile.lock in top-level directory
1 parent 3d99509 commit da79b17

File tree

4 files changed

+22
-8
lines changed

4 files changed

+22
-8
lines changed

Rakefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ namespace :bundle do
8282
end
8383
sh "rm -f #{__current__.join('elasticsearch-model/gemfiles')}/*.lock"
8484
end
85+
sh "rm -f Gemfile.lock"
8586
end
8687

8788
namespace :test do

elasticsearch-model/gemfiles/6.0.gemfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ source 'https://rubygems.org'
2525

2626
gemspec path: '../'
2727

28-
gem 'activemodel', '6.0.0.rc1'
29-
gem 'activerecord', '6.0.0.rc1'
28+
gem 'activemodel', '6.0.0'
29+
gem 'activerecord', '6.0.0'
3030
gem 'sqlite3' unless defined?(JRUBY_VERSION)
31-
gem 'mongoid', '~> 6'
31+
#gem 'mongoid', '~> 6'
3232

3333
group :development, :testing do
3434
gem 'rspec'

elasticsearch-model/spec/spec_helper.rb

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@
2323
require 'elasticsearch/model'
2424
require 'hashie/version'
2525
require 'active_model'
26-
require 'mongoid'
26+
begin
27+
require 'mongoid'
28+
rescue LoadError
29+
$stderr.puts("'mongoid' gem could not be loaded")
30+
end
2731
require 'yaml'
2832
require 'active_record'
2933

@@ -151,8 +155,10 @@ def test_mongoid?
151155
client.database.command(ping: 1) && true
152156
end
153157
end and true
154-
rescue Timeout::Error, LoadError, Mongo::Error => e
155-
client.close
158+
rescue LoadError
159+
$stderr.puts("'mongoid' gem could not be loaded")
160+
rescue Timeout::Error, Mongo::Error => e
161+
client.close if client
156162
$stderr.puts("MongoDB not installed or running: #{e}")
157163
end
158164
end

elasticsearch-model/spec/support/app.rb

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@
2626
require 'support/app/article_for_pagination'
2727
require 'support/app/article_with_dynamic_index_name'
2828
require 'support/app/episode'
29-
require 'support/app/image'
3029
require 'support/app/series'
31-
require 'support/app/mongoid_article'
3230
require 'support/app/article'
3331
require 'support/app/article_no_type'
3432
require 'support/app/searchable'
@@ -37,3 +35,12 @@
3735
require 'support/app/authorship'
3836
require 'support/app/comment'
3937
require 'support/app/post'
38+
39+
40+
# Mongoid models
41+
begin
42+
require 'support/app/image'
43+
require 'support/app/mongoid_article'
44+
rescue
45+
$stderr.puts("'mongoid' gem is not installed, could not load Mongoid models")
46+
end

0 commit comments

Comments
 (0)