Skip to content

Commit 709ff24

Browse files
authored
Add back private knn_search API for rest-api-spec generation (#5737)
* Revert "Remove knn_search API (#4276)" This reverts commit 2a24e33 since _knn_search is still needed in rest-api-spec to run YAML tests against it, as the API is still available with v8 compatibility mode. However, we make the API private so that it does not get back into clients, as it would fail with v9 compatibility. * Add UpdateForV10 annotation * Fix lint
1 parent bcc1230 commit 709ff24

File tree

6 files changed

+555
-6
lines changed

6 files changed

+555
-6
lines changed

compiler/src/model/utils.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1074,7 +1074,9 @@ export function parseJsDocTags (jsDoc: JSDoc[]): Record<string, string> {
10741074
value: tag.getComment() ?? ''
10751075
}
10761076
})
1077-
const mapped = tags.reduce((acc, curr) => ({ ...acc, [curr.name]: curr.value }), {})
1077+
// Ignore UpdateForV10 which is only useful at the eslint level
1078+
const filteredTags = tags.filter(tag => tag.name !== 'UpdateForV10')
1079+
const mapped = filteredTags.reduce((acc, curr) => ({ ...acc, [curr.name]: curr.value }), {})
10781080
return mapped
10791081
}
10801082

output/schema/schema.json

Lines changed: 337 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)