Skip to content

Adding index.refresh_interval as a data stream setting #131482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

Adding index.refresh_interval as a data stream setting #131482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...in/java/org/elasticsearch/datastreams/action/TransportUpdateDataStreamSettingsAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ public class TransportUpdateDataStreamSettingsAction extends TransportMasterNode
UpdateDataStreamSettingsAction.Request,
UpdateDataStreamSettingsAction.Response> {
private static final Logger logger = LogManager.getLogger(TransportUpdateDataStreamSettingsAction.class);
private static final Set<String> APPLY_TO_BACKING_INDICES = Set.of("index.lifecycle.name", IndexSettings.PREFER_ILM);
private static final Set<String> APPLY_TO_BACKING_INDICES = Set.of(
"index.lifecycle.name",
IndexSettings.PREFER_ILM,
"index.refresh_interval"
);
private static final Set<String> APPLY_TO_DATA_STREAM_ONLY = Set.of("index.number_of_shards");
private final MetadataDataStreamsService metadataDataStreamsService;
private final MetadataUpdateSettingsService updateSettingsService;
Expand Down
8 changes: 7 additions & 1 deletion ...ms/src/yamlRestTest/resources/rest-api-spec/test/data_stream/240_data_stream_settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,21 @@ setup:
body:
index:
number_of_shards: 2
refresh_interval: 29s
lifecycle:
name: my-new-policy
prefer_ilm: true
- match: { data_streams.0.name: my-data-stream-1 }
- match: { data_streams.0.applied_to_data_stream: true }
- match: { data_streams.0.index_settings_results.applied_to_data_stream_only: [index.number_of_shards]}
- length: { data_streams.0.index_settings_results.applied_to_data_stream_and_backing_indices: 2 }
- length: { data_streams.0.index_settings_results.applied_to_data_stream_and_backing_indices: 3 }
- match: { data_streams.0.settings.index.number_of_shards: "2" }
- match: { data_streams.0.settings.index.refresh_interval: "29s" }
- match: { data_streams.0.settings.index.lifecycle.name: "my-new-policy" }
- match: { data_streams.0.settings.index.lifecycle.prefer_ilm: "true" }
- match: { data_streams.0.effective_settings.index.number_of_shards: "2" }
- match: { data_streams.0.effective_settings.index.number_of_replicas: "0" }
- match: { data_streams.0.effective_settings.index.refresh_interval: "29s" }
- match: { data_streams.0.effective_settings.index.lifecycle.name: "my-new-policy" }
- match: { data_streams.0.effective_settings.index.lifecycle.prefer_ilm: "true" }

Expand All @@ -81,6 +84,7 @@ setup:
- match: { data_streams.0.name: my-data-stream-1 }
- match: { data_streams.0.settings.index.number_of_shards: "2" }
- match: { data_streams.0.effective_settings.index.number_of_shards: "2" }
- match: { data_streams.0.effective_settings.index.refresh_interval: "29s" }
- match: { data_streams.0.effective_settings.index.number_of_replicas: "0" }
- match: { data_streams.0.effective_settings.index.lifecycle.name: "my-new-policy" }
- match: { data_streams.0.effective_settings.index.lifecycle.prefer_ilm: "true" }
Expand All @@ -90,6 +94,7 @@ setup:
name: my-data-stream-1
- match: { data_streams.0.name: my-data-stream-1 }
- match: { data_streams.0.settings.index.number_of_shards: "2" }
- match: { data_streams.0.settings.index.refresh_interval: "29s" }
- match: { data_streams.0.settings.index.lifecycle.name: "my-new-policy" }
- match: { data_streams.0.settings.index.lifecycle.prefer_ilm: "true" }
- match: { data_streams.0.effective_settings: null }
Expand All @@ -106,6 +111,7 @@ setup:
- match: { .$idx0name.settings.index.number_of_shards: "1" }
- match: { .$idx0name.settings.index.lifecycle.name: "my-new-policy" }
- match: { .$idx1name.settings.index.number_of_shards: "2" }
- match: { .$idx1name.settings.index.refresh_interval: "29s" }
- match: { .$idx1name.settings.index.lifecycle.name: "my-new-policy" }
- match: { .$idx1name.settings.index.lifecycle.prefer_ilm: "true" }

Expand Down