Avatar not shown at all if permission can not be changed

[mxandreas]

Steps to reproduce

1. Jim create a room.
2. Jim upgrades room to v12.
3. Jim invites Andreas to the room.
4. Jim makes Andreas an Admin.
5. Jim goes to the Roles and permissions > Edit Owners or Admins

Outcome

What did you expect?

Jim's (own) avatar appears in the horizontal bar at the top because they are an admin, however the close/remove button does not appear on the avatar, because Jim can't change his own permission (the corresponding checkbox below is also disabled).

What happened instead?

Jim's (own) avatar does not appear at all at the top, making the view inconsistent - e.g. Jim is actually an owner (checkbox checked below) but avatar not shown at the top.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

No

[mxandreas]

iOS provides a consistent view which was desired in the designs. The main point of the avatars at the top is to be clear of which users actually have the permission (there may be just a few) while the list of users below may be long and it may be hard to get an overview of for which of them the checkbox is checked.

[bmarty]

I tried to repro the issue but I can't. In the screenshot below, after benoitx has created the room, invited Benoit, they joined, made him an admin, here is what I get:

Am I missing something? Maybe the room has to be upgraded to version 12 first? Element Web and EXA created rooms with version 10 at the moment.

An issue I have though is that I cannot demote Benoit. The UI allow it but then an error occurs.

[mxandreas]

@bmarty Yes, you're right. To reproduce this specific issue, you would need to upgrade the room to v12. I have updated the description accordingly.

With v10 it works as expected.

[bmarty]

Thanks, #5736 should fix the issue