-
-
Notifications
You must be signed in to change notification settings - Fork 80
Window: DynamicNotebook → Hdy.TabBar #2256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jeremypw I'm not sure how to solve creating a new window without the default tab. I'd appreciate help there since you know a lot more than I do about how Files creates new windows! Otherwise, I think this is ready for your feedback/review :) |
Yes, the order of events is different now so we need to be able to create a tabview with no tabs to return. At the moment, if no path is passed to |
jeremypw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work now. There are new critical warnings when tabs and windows are closed but they can be addressed separately if wished.
Fixes #1339
Todo: