Skip to content

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 12, 2023

Fixes #1339

  • Use Hdy.TabBar instead of Granite.DynamicNotebook
  • Reorder tab menu items to match Epiphany while we're here
  • Double click to add tab and tab bar context menu are gone, doesn't seem to be a safe way to do this. These can't be accessed when the tab bar is full anyways and they duplicate functionality that already exists.

Todo:

  • Dragging tab into a new window also creates home folder tab

@jeremypw
Copy link
Contributor

jeremypw commented Jul 13, 2023

Should be able to cherry-pick a lot from #2225 commit ca8c3b3. Although that PR uses Adw widgets the interface is practically the same.

@danirabbit danirabbit marked this pull request as ready for review July 17, 2023 00:11
@danirabbit danirabbit requested a review from jeremypw July 17, 2023 00:12
@danirabbit
Copy link
Member Author

@jeremypw I'm not sure how to solve creating a new window without the default tab. I'd appreciate help there since you know a lot more than I do about how Files creates new windows! Otherwise, I think this is ready for your feedback/review :)

@danirabbit danirabbit requested a review from jeremypw July 17, 2023 14:31
@jeremypw
Copy link
Contributor

@jeremypw I'm not sure how to solve creating a new window without the default tab. I'd appreciate help there since you know a lot more than I do about how Files creates new windows! Otherwise, I think this is ready for your feedback/review :)

Yes, the order of events is different now so we need to be able to create a tabview with no tabs to return. At the moment, if no path is passed to create_window then the default tab is created. I'll propose something.

Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work now. There are new critical warnings when tabs and windows are closed but they can be addressed separately if wished.

@jeremypw jeremypw merged commit e5fc01c into main Jul 19, 2023
@jeremypw jeremypw deleted the danirabbit/hdytabbar branch July 19, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When Single Tab, DnD will create a new window (Design)

3 participants