Do not log exits on IEx.Helpers.c failures

Signed-off-by: José Valim <[email protected]>

Author: José Valim

lib/iex/lib/iex/helpers.ex

@@ -158,7 +158,7 @@ defmodule IEx.Helpers do
 
     {erls, exs} = Enum.split_with(found, &String.ends_with?(&1, ".erl"))
 
-    modules = Enum.map(erls, fn(source) ->
+    erl_modules = Enum.map(erls, fn(source) ->
       {module, binary} = compile_erlang(source)
       unless path == :in_memory do
         base = source |> Path.basename |> Path.rootname
@@ -167,7 +167,13 @@ defmodule IEx.Helpers do
       module
     end)
 
-    modules ++ compile_elixir(exs, path)
+    ex_modules = try do
+      compile_elixir(exs, path)
+    catch
+      _, _ -> raise CompileError
+    end
+
+    erl_modules ++ ex_modules
   end
 
   @doc """

lib/iex/test/iex/helpers_test.exs

@@ -296,19 +296,12 @@ defmodule IEx.HelpersTest do
     cleanup_modules([Sample])
   end
 
-  test "c/2 helper" do
-    assert_raise UndefinedFunctionError, ~r"function Sample\.run/0 is undefined", fn ->
-      Sample.run
-    end
-
-    filename = "sample.ex"
-    with_file filename, test_module_code(), fn ->
-      assert c(filename, ".") == [Sample]
-      assert File.exists?("Elixir.Sample.beam")
-      assert Sample.run == :run
+  test "c helper with error" do
+    ExUnit.CaptureIO.capture_io fn ->
+      with_file "sample.ex", "raise \"oops\"", fn ->
+        assert_raise CompileError, fn -> c("sample.ex") end
+      end
     end
-  after
-    cleanup_modules([Sample])
   end
 
   test "c helper with full path" do
@@ -366,21 +359,6 @@ defmodule IEx.HelpersTest do
     cleanup_modules([:sample])
   end
 
-  test "c/2 helper erlang" do
-    assert_raise UndefinedFunctionError, ~r"function :sample.hello/0 is undefined", fn ->
-      :sample.hello
-    end
-
-    filename = "sample.erl"
-    with_file filename, erlang_module_code(), fn ->
-      assert c(filename, ".") == [:sample]
-      assert :sample.hello == :world
-      assert File.exists?("sample.beam")
-    end
-  after
-    cleanup_modules([:sample])
-  end
-
   test "c helper skips unknown files" do
     assert_raise UndefinedFunctionError, ~r"function :sample.hello/0 is undefined", fn ->
       :sample.hello
@@ -396,6 +374,20 @@ defmodule IEx.HelpersTest do
     cleanup_modules([:sample, Sample2])
   end
 
+  test "c helper with path" do
+    assert_raise UndefinedFunctionError, ~r"function Sample\.run/0 is undefined", fn ->
+      Sample.run
+    end
+
+    filename = "sample.ex"
+    with_file filename, test_module_code(), fn ->
+      assert c(filename, ".") == [Sample]
+      assert File.exists?("Elixir.Sample.beam")
+      assert Sample.run == :run
+    end
+  after
+    cleanup_modules([Sample])
+  end
 
   test "l helper" do
     assert_raise UndefinedFunctionError, ~r"function Sample.run/0 is undefined", fn ->