feat: Report exit status globally

Author: jcs090218

lisp/_prepare.el

@@ -1432,7 +1432,29 @@ This uses function `locate-dominating-file' to look up directory tree."
                  (ignore-errors (make-directory package-user-dir t))
                  (eask--silent (eask-setup-paths))
                  (eask-with-verbosity 'debug (eask--load-config))
-                 (eask--with-hooks ,@body))))))))))
+                 (eask--with-hooks ,@body))))))
+         ;; Report exit stats if any.
+         (eask--handle-exit-status)))))
+
+(defun eask--error-status ()
+  "Return error status."
+  (let ((result))
+    ;; Error.
+    (when eask--has-error-p
+      (push 'error result))
+    ;; Warning.
+    (when eask--has-warn-p
+      (push (if (eask-strict-p)
+                'error
+              'warn)
+            result))
+    ;; No repeat.
+    (delete-dups result)))
+
+(defun eask--handle-exit-status ()
+  "Return non-nil if we should report error for exit status."
+  (when (memq 'error (eask--error-status))
+    (eask--exit 'failure)))
 
 ;;
 ;;; Eask file
@@ -2000,7 +2022,7 @@ Argument ARGS are direct arguments for functions `eask-error' or `eask-warn'."
   "On error.
 
 Arguments FNC and ARGS are used for advice `:around'."
-  (setq eask--has-error-p t)
+  (setq eask--has-error-p t)  ; Just a record.
   (let ((msg (eask--ansi 'error (apply #'format-message args))))
     (unless eask-inhibit-error-message
       (eask--unsilent (eask-msg "%s" msg)))
@@ -2012,7 +2034,7 @@ Arguments FNC and ARGS are used for advice `:around'."
   "On warn.
 
 Arguments FNC and ARGS are used for advice `:around'."
-  (setq eask--has-warn-p t)
+  (setq eask--has-warn-p t)  ; Just a record.
   (let ((msg (eask--ansi 'warn (apply #'format-message args))))
     (unless eask-inhibit-error-message
       (eask--unsilent (eask-msg "%s" msg)))

lisp/lint/elint.el

@@ -44,11 +44,6 @@
       (eask-print-log-buffer log-buffer)
       (kill-buffer log-buffer))))
 
-(defun eask-lint-elint--has-error-p ()
-  "Return non-nil if we should report error for exit status."
-  (and eask--has-warn-p
-       (eask-strict-p)))
-
 (eask-start
   (require 'elint)
   (let* ((patterns (eask-args))
@@ -62,10 +57,7 @@
       (eask-msg "")
       (eask-info "(Total of %s file%s %s checked)" (length files)
                  (eask--sinr files "" "s")
-                 (eask--sinr files "has" "have"))
-      ;; Report error.
-      (when (eask-lint-elint--has-error-p)
-        (eask--exit 'failure)))
+                 (eask--sinr files "has" "have")))
      ;; Pattern defined, but no file found!
      (patterns
       (eask-info "(No files match wildcard: %s)"

lisp/lint/elsa.el

@@ -60,12 +60,6 @@
                   (t (eask-log line)))))
       (eask-msg "No issues found"))))
 
-(defun eask-lint-elsa--has-error-p ()
-  "Return non-nil if we should report error for exit status."
-  (or eask--has-error-p
-      (and eask--has-warn-p
-           (eask-strict-p))))
-
 (eask-start
   ;; Preparation
   (eask-archive-install-packages '("gnu" "melpa")
@@ -85,10 +79,7 @@
       (mapcar #'eask-lint-elsa--analyse-file files)
       (eask-msg "")
       (eask-info "(Total of %s file%s linted)" (length files)
-                 (eask--sinr files "" "s"))
-      ;; Report error.
-      (when (eask-lint-elsa--has-error-p)
-        (eask--exit 'failure)))
+                 (eask--sinr files "" "s")))
      ;; Pattern defined, but no file found!
      (patterns
       (eask-msg "")

lisp/lint/package.el

@@ -57,11 +57,6 @@
       (kill-current-buffer)))
   (eask-print-log-buffer "*Package-Lint*"))
 
-(defun eask-lint-package--has-error-p ()
-  "Return non-nil if we should report error for exit status."
-  (and eask--has-warn-p
-       (eask-strict-p)))
-
 (eask-start
   ;; Preparation
   (eask-archive-install-packages '("gnu" "melpa")
@@ -82,10 +77,7 @@
       (mapcar #'eask-lint-package--file files)
       (eask-msg "")
       (eask-info "(Total of %s file%s linted)" (length files)
-                 (eask--sinr files "" "s"))
-      ;; Report error.
-      (when (eask-lint-package--has-error-p)
-        (eask--exit 'failure)))
+                 (eask--sinr files "" "s")))
      ;; Pattern defined, but no file found!
      (patterns
       (eask-msg "")

lisp/lint/regexps.el

@@ -61,11 +61,6 @@
         (eask-msg "No issues found"))
       (kill-current-buffer))))
 
-(defun eask-lint-regexps--has-error-p ()
-  "Return non-nil if we should report error for exit status."
-  (and eask--has-warn-p
-       (eask-strict-p)))
-
 (eask-start
   ;; Preparation
   (eask-archive-install-packages '("gnu")
@@ -85,10 +80,7 @@
       (mapcar #'eask-lint-regexps--relint-file files)
       (eask-msg "")
       (eask-info "(Total of %s file%s linted)" (length files)
-                 (eask--sinr files "" "s"))
-      ;; Report error.
-      (when (eask-lint-regexps--has-error-p)
-        (eask--exit 'failure)))
+                 (eask--sinr files "" "s")))
      ;; Pattern defined, but no file found!
      (patterns
       (eask-msg "")