fix(lisp): Don't assume a list representation in `eask-current-time'

`eask-current-time' rebuilt a seconds count from the first two elements
of `current-time'. That representation is not guaranteed: it depends on
`current-time-list', which defaults to nil as of Emacs 32, so
`current-time' returns a (TICKS . HZ) cons cell rather than a
(HIGH LOW USEC PSEC) list.

`(cadr now)' then evaluates `(car 1000000000)', and `eask package' aborts
with "Wrong type argument: listp, 1000000000", where the number is the HZ
value from the cons cell.

Use `float-time', which accepts either representation and is available in
every Emacs version Eask supports (the declared floor is 26.1, so
`time-convert' is not an option). The result is unchanged for the list
representation.

Fixes #431.

Author: alberti42

lisp/_prepare.el

@@ -311,8 +311,12 @@ Argument BODY are forms for execution."
 
 ;; This is used to creating the directory recipe!
 (defun eask-current-time ()
-  "Return current time."
-  (let ((now (current-time))) (logior (ash (car now) 16) (cadr now))))
+  "Return current time, as a count of seconds since the epoch."
+  ;; Don't take `current-time' apart by hand: its representation depends on
+  ;; `current-time-list', which defaults to nil as of Emacs 32 and then yields
+  ;; a (TICKS . HZ) pair rather than a (HIGH LOW USEC PSEC) list.  `float-time'
+  ;; accepts either form and exists in every Emacs version Eask supports.
+  (floor (float-time)))
 
 (defun eask-seq-str-max (sequence)
   "Return max length in SEQUENCE of strings."