Make flycheck-phpstan use --error-format=json instead of "raw"

Author: zonuexe

flycheck-phpstan.el

@@ -43,6 +43,7 @@
 
 ;; Usually it is defined dynamically by flycheck
 (defvar flycheck-phpstan-executable)
+(defvar flycheck-phpstan--temp-buffer-name "*Flycheck PHPStan*")
 
 (defun flycheck-phpstan--enabled-and-set-variable ()
   "Return path to phpstan configure file, and set buffer execute in side effect."
@@ -60,17 +61,48 @@
                      (null phpstan-executable)))
         (setq-local flycheck-phpstan-executable (car (phpstan-get-executable-and-args)))))))
 
+(defun flycheck-phpstan-parse-output (output &optional _checker _buffer)
+  "Parse PHPStan errors from OUTPUT."
+  (with-current-buffer (flycheck-phpstan--temp-buffer)
+    (erase-buffer)
+    (insert output))
+  (flycheck-phpstan-parse-json (flycheck-phpstan--temp-buffer)))
+
+(defun flycheck-phpstan--temp-buffer ()
+  "Return a temporary buffer for decode JSON."
+  (get-buffer-create flycheck-phpstan--temp-buffer-name))
+
+(defun flycheck-phpstan-parse-json (json-buffer)
+  "Parse PHPStan errors from JSON-BUFFER."
+  (let ((data (phpstan--parse-json json-buffer)))
+    (cl-loop for (file . entry) in (flycheck-phpstan--plist-to-alist (plist-get data :files))
+             append (cl-loop for messages in (plist-get entry :messages)
+                             for text = (let ((msg (plist-get messages :message))
+                                              (tip (plist-get messages :tip)))
+                                          (if tip
+                                              (concat msg "\n" phpstan-tip-message-prefix tip)
+                                            msg))
+                             collect (flycheck-error-new-at (plist-get messages :line)
+                                                            nil 'error text
+                                                            :filename file)))))
+
+(defun flycheck-phpstan--plist-to-alist (plist)
+  "Convert PLIST to association list."
+  (let (alist)
+    (while plist
+      (push (cons (substring-no-properties (symbol-name (pop plist)) 1) (pop plist)) alist))
+    (nreverse alist)))
+
 (flycheck-define-checker phpstan
   "PHP static analyzer based on PHPStan."
-  :command ("php" (eval (phpstan-get-command-args))
+  :command ("php" (eval (phpstan-get-command-args :format "json"))
             (eval (if (or (buffer-modified-p) (not buffer-file-name))
                       (phpstan-normalize-path
                        (flycheck-save-buffer-to-temp #'flycheck-temp-file-inplace))
                     buffer-file-name)))
   :working-directory (lambda (_) (phpstan-get-working-dir))
   :enabled (lambda () (flycheck-phpstan--enabled-and-set-variable))
-  :error-patterns
-  ((error line-start (1+ (not (any ":"))) ":" line ":" (message) line-end))
+  :error-parser flycheck-phpstan-parse-output
   :modes (php-mode phps-mode))
 
 (add-to-list 'flycheck-checkers 'phpstan t)